From: Tristan Partin <tristan@neon.tech>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Missing dep on Catalog.pm in meson rules
Date: Thu, 01 Jun 2023 23:06:04 -0500
Message-ID: <CT1V90ZD4ZPZ.2J5QU7ZEYSB60@gonk> (raw)
In-Reply-To: <329a690c-1f4e-4759-8018-8ee562c159f0@app.fastmail.com>
References: <87v8g7s6bf.fsf@wibble.ilmari.org>
<CT1MJFE3PEEV.2S08CXLDYMCWP@gonk>
<329a690c-1f4e-4759-8018-8ee562c159f0@app.fastmail.com>
On Thu Jun 1, 2023 at 4:22 PM CDT, Dagfinn Ilmari Mannsåker wrote:
> On Thu, 1 Jun 2023, at 22:16, Tristan Partin wrote:
> > Could you create a variable for the file instead of calling files() 3
> > times?
> >
> >> catalog_pm = files('path/to/Catalog.pm')
>
> Sure, but which meson.build file should it go in? I know nothing about meson variable scoping.
Not a problem. In Meson, variables are globally-scoped. You can use
unset_variable() however to unset it.
In our case, we should add the ^line to src/backend/catalog/meson.build.
I would say just throw the line after the copyright comment. Hopefully
there isn't a problem with the ordering of the Meson file tree traversal
(ie the targets you are changing are configured after we get through
src/backend/catalog/meson.build).
--
Tristan Partin
Neon (https://neon.tech)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tristan@neon.tech, ilmari@ilmari.org
Subject: Re: [PATCH] Missing dep on Catalog.pm in meson rules
In-Reply-To: <CT1V90ZD4ZPZ.2J5QU7ZEYSB60@gonk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox