From: Tristan Partin <tristan@neon.tech>
To: Andres Freund <andres@anarazel.de>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Missing dep on Catalog.pm in meson rules
Date: Fri, 02 Jun 2023 10:13:44 -0500
Message-ID: <CT29G866OR1A.P5MR0P1UF545@gonk> (raw)
In-Reply-To: <20230602134704.w2gg7nwe2jisd7es@alap3.anarazel.de>
References: <87v8g7s6bf.fsf@wibble.ilmari.org>
<CT1MJFE3PEEV.2S08CXLDYMCWP@gonk>
<329a690c-1f4e-4759-8018-8ee562c159f0@app.fastmail.com>
<CT1V90ZD4ZPZ.2J5QU7ZEYSB60@gonk>
<20230602130028.yf4jagpqqmivhx77@alap3.anarazel.de>
<CT26U28ECWTA.3VIVYB9J55L4K@gonk>
<20230602134704.w2gg7nwe2jisd7es@alap3.anarazel.de>
On Fri Jun 2, 2023 at 8:47 AM CDT, Andres Freund wrote:
> Hi,
>
> On 2023-06-02 08:10:43 -0500, Tristan Partin wrote:
> > > I wonder if we instead could just make perl output the files it loads and
> > > handle dependencies automatically that way? But that's more work, so it's
> > > probably the right thing to go for the manual path for now.
> >
> > I am not familar with Perl enough (at all haha) to know if that is
> > possible. I don't know exactly what these Perl files do, but perhaps it
> > might make sense to have some global lookup table that is setup near the
> > beginning of the script.
>
> It'd be nice to have something more general - there are other perl modules we
> load, e.g.
> ./src/backend/catalog/Catalog.pm
> ./src/backend/utils/mb/Unicode/convutils.pm
> ./src/tools/PerfectHash.pm
>
>
> > perl_files = {
> > 'Catalog.pm': files('path/to/Catalog.pm'),
> > ...
> > }
>
> I think you got it, but just to make sure: I was thinking of generating a
> depfile from within perl. Something like what you propose doesn't quite seems
> like a sufficient improvement.
Whatever I am proposing is definitely subpar to generating a depfile. So
if that can be done, that is the best option!
> > Otherwise, manual as it is in the original patch seems like an alright
> > compromise for now.
>
> Yea. I'm working on a more complete version, also dealing with dependencies on
> PerfectHash.pm.
Good to hear. Happy to review any patches :).
--
Tristan Partin
Neon (https://neon.tech)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tristan@neon.tech, andres@anarazel.de, ilmari@ilmari.org
Subject: Re: [PATCH] Missing dep on Catalog.pm in meson rules
In-Reply-To: <CT29G866OR1A.P5MR0P1UF545@gonk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox