From: Tristan Partin <tristan@neon.tech>
To: Peter Eisentraut <peter@eisentraut.org>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Meson build updates
Date: Mon, 12 Jun 2023 16:43:29 -0500
Message-ID: <CTB00342PAX7.36RK20RD57EUH@gonk> (raw)
In-Reply-To: <277c356e-7ef7-4c87-f4b2-97a13914dd02@eisentraut.org>
References: <CSPIJVUDZFKX.3KHMOAVGF94RV@c3po>
<20230609164135.77fjwqkqzdxfs3f5@awork3.anarazel.de>
<CT8BP7BRV4A2.AOE7263UX2SH@gonk>
<20230609183603.o56z3ngtak6qhb3s@awork3.anarazel.de>
<CTATUZLNWYKO.2PMYWTUA85JUK@gonk>
<20230612172038.f2xf2cwlnhjldqng@awork3.anarazel.de>
<CTAW8GBWEJ7F.129Y59WDVDNMW@gonk>
<277c356e-7ef7-4c87-f4b2-97a13914dd02@eisentraut.org>
On Mon Jun 12, 2023 at 4:24 PM CDT, Peter Eisentraut wrote:
> On 12.06.23 20:48, Tristan Partin wrote:
> > Attached you will find a v3 with the offending commits removed. I did
> > leave the overrides in since you didn't mention it in your last email.
>
> Patches 1-14 look ok to me. (But I didn't test anything, so some
> caveats about whether the non-cosmetic patches actually work apply.) If
> we're fine-tuning the capitalization the options descriptions, let's
> also turn "tap tests" into "TAP tests" and "TCL" into "Tcl".
I'll get to that.
> Patch 15 about the wrap integration, I'm not sure. I share the concerns
> about whether this is worth maintaining. Maybe put this patch into the
> commitfest separately, to allow for further study and testing. (The
> other patches, if they are acceptable, ought to go into PG16, I think.)
Ok. I will split it off for further discussion. Expect a v4 tomorrow
with a few extra changes with regard to another review from a Meson
maintainer.
--
Tristan Partin
Neon (https://neon.tech)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tristan@neon.tech, peter@eisentraut.org, andres@anarazel.de
Subject: Re: Meson build updates
In-Reply-To: <CTB00342PAX7.36RK20RD57EUH@gonk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox