pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tristan Partin <tristan@partin.io>
To: Andres Freund <andres@anarazel.de>
To: Dave Page <dpage@pgadmin.org>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Meson far from ready on Windows
Date: Tue, 16 Jul 2024 15:53:45 -0500
Message-ID: <D2R9FY2W0D7S.249249RYHGISR@partin.io> (raw)
In-Reply-To: <20240709065101.xhc74r3mdg2lmn4w@awork3.anarazel.de>
References: <20240618143850.nl67cwctsodmgfpi@awork3.anarazel.de>
	<CA+OCxoxwwA7u3mw9r7+miRzxdwzet9=Xq3JxVFpkd6TajP9eGA@mail.gmail.com>
	<20240618160845.gbqkiv4dbjghlp63@awork3.anarazel.de>
	<CA+OCxozsg3NOkTfK4KCb0gmxwnaNv4P=yuMZe_CgeXTM=ZGW7g@mail.gmail.com>
	<20240620205849.whd3434zoqqm2iy4@awork3.anarazel.de>
	<CA+OCxoxJ075+R63sgsHBExB+x3BV3o1xs9EBxGEuYmZQOkW=UQ@mail.gmail.com>
	<20240625104145.b255idixhgq4hrrx@alap3.anarazel.de>
	<CA+OCxozhkrfLe=ZUt4fcs3G-Qew30e5H37AL7o7aZ3bC54TAoQ@mail.gmail.com>
	<20240625113906.7gecsoyjcqjrejiz@alap3.anarazel.de>
	<CA+OCxozShTj4eBn5wtjQ16bL3qMq1ETO_CBCMHFfXcvQyZSZaw@mail.gmail.com>
	<20240709065101.xhc74r3mdg2lmn4w@awork3.anarazel.de>

> From 9f7c96dfab4d807e668c9d32b44db5f4ff122e15 Mon Sep 17 00:00:00 2001
> From: Andres Freund <andres@anarazel.de>
> Date: Mon, 8 Jul 2024 15:55:56 -0700
> Subject: [PATCH v2 02/10] Don't define HAVE_[GSSAPI_]GSSAPI_EXT_H
> 
> The check for gssapi_ext.h was added in f7431bca8b0. As we require
> gssapi_ext.h to be present, there's no point in defining symbols for the
> header presence.
> 
> While at it, use cc.has_header() instead of cc.check_header(), that's a bit
> cheaper and it seems improbably that gssapi.h would compile while gssapi_ext.h
> would not.

improbable

Other than that, it looks pretty solid. Looks like we could help future 
us out by teaching compiler.find_library() to take a list of names to 
look at similar to how dependency() works now.

Reviewed-by: Tristan Partin <tristan@partin.io>

-- 
Tristan Partin
Neon (https://neon.tech)





view thread (31+ messages)  latest in thread

Message-ID: <D2R9FY2W0D7S.249249RYHGISR@partin.io>
Permalink:  ../D2R9FY2W0D7S.249249RYHGISR@partin.io/
Also on:    postgresql.org/message-id/D2R9FY2W0D7S.249249RYHGISR@partin.io

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tristan@partin.io, andres@anarazel.de, dpage@pgadmin.org, byavuz81@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Meson far from ready on Windows
  In-Reply-To: <D2R9FY2W0D7S.249249RYHGISR@partin.io>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox