From: Chao Li <li.evan.chao@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: vacuumdb: add --dry-run
Date: Tue, 9 Dec 2025 07:04:24 +0800
Message-ID: <D34BB1FD-C704-4855-804D-932C054B1981@gmail.com> (raw)
In-Reply-To: <aTcmCNuBamK1xwu5@nathan>
References: <aTcUSHQniPgksgC5@nathan>
<202512081821.lruaedzh3qkr@alvherre.pgsql>
<aTcYjvO7f-9DXbrk@nathan>
<aTcmCNuBamK1xwu5@nathan>
> On Dec 9, 2025, at 03:24, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Mon, Dec 08, 2025 at 12:27:26PM -0600, Nathan Bossart wrote:
>> On Mon, Dec 08, 2025 at 07:23:16PM +0100, Álvaro Herrera wrote:
>>> I haven't read this thread, but chanced to come across this and wanted
>>> to note recent commit c05dee191125. I'm not opposed to changing what
>>> went in there, but let's make them all the same.
>>
>> Ah, that must've been where I stole from originally. Will switch it back.
>
> As promised...
>
> --
> nathan
> <v7-0001-vacuumdb-Move-some-options-to-vacuumingOptions-st.patch><v7-0002-Add-ParallelSlotSetIdle.patch><v7-0003-vacuumdb-Add-dry-run.patch>
I searched over the source tree, and find “Running in xxx mode” in initdb and option.c:
Initdb:
```
printf(_("Running in debug mode.\n"));
printf(_("Running in no-clean mode. Mistakes will not be cleaned up.\n"));```
Options.
```
pg_log(PG_REPORT, "Running in verbose mode”);
```
And “”Executing in dry-run mode” in a few commands: pg_archivecleanup.c, pg_createsubscriber.c, pg_combinebackup.c and pg_rewind.c.
Should we make them all consistent?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: li.evan.chao@gmail.com, nathandbossart@gmail.com, alvherre@kurilemu.de, corey.huinker@gmail.com
Subject: Re: vacuumdb: add --dry-run
In-Reply-To: <D34BB1FD-C704-4855-804D-932C054B1981@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox