public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 13/18] doc review for FDW bulk inserts 3+ messages / 3 participants [nested] [flat]
* [PATCH 13/18] doc review for FDW bulk inserts @ 2021-01-23 23:17 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Justin Pryzby @ 2021-01-23 23:17 UTC (permalink / raw) b663a4136331de6c7364226e3dbf7c88bfee7145 --- doc/src/sgml/fdwhandler.sgml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/fdwhandler.sgml b/doc/src/sgml/fdwhandler.sgml index 854913ae5f..12e00bfc2f 100644 --- a/doc/src/sgml/fdwhandler.sgml +++ b/doc/src/sgml/fdwhandler.sgml @@ -672,9 +672,8 @@ GetForeignModifyBatchSize(ResultRelInfo *rinfo); Report the maximum number of tuples that a single <function>ExecForeignBatchInsert</function> call can handle for - the specified foreign table. That is, The executor passes at most - the number of tuples that this function returns to - <function>ExecForeignBatchInsert</function>. + the specified foreign table. The executor passes at most + the given number of tuples to <function>ExecForeignBatchInsert</function>. <literal>rinfo</literal> is the <structname>ResultRelInfo</structname> struct describing the target foreign table. The FDW is expected to provide a foreign server and/or foreign -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0014-doc-review-logical-decode-in-prepare.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
* doc: join state for merge join @ 2022-02-19 13:20 Zhihong Yu <[email protected]> 2022-02-19 19:24 ` Re: doc: join state for merge join Daniel Gustafsson <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Zhihong Yu @ 2022-02-19 13:20 UTC (permalink / raw) To: PostgreSQL Developers <[email protected]> Hi, When i was looking at the code for ExecMergeJoin(), I noticed a few places where the join state name in the comment doesn't match the actual state. Here is a small patch with correction. Cheers Attachments: [application/octet-stream] merge-join-state-doc.patch (1.2K, ../../CALNJ-vQVthfQXVqmrHR8BKHtC4fMGbhM1xbvJNJAPexTq_dH=w@mail.gmail.com/3-merge-join-state-doc.patch) download | inline diff: diff --git a/src/backend/executor/nodeMergejoin.c b/src/backend/executor/nodeMergejoin.c index a049bc4ae0..933b878caa 100644 --- a/src/backend/executor/nodeMergejoin.c +++ b/src/backend/executor/nodeMergejoin.c @@ -1143,7 +1143,7 @@ ExecMergeJoin(PlanState *pstate) break; /*---------------------------------------------------------- - * EXEC_MJ_SKIP means compare tuples and if they do not + * EXEC_MJ_SKIP_TEST means compare tuples and if they do not * match, skip whichever is lesser. * * For example: @@ -1199,7 +1199,7 @@ ExecMergeJoin(PlanState *pstate) break; /* - * SKIPOUTER_ADVANCE: advance over an outer tuple that is + * EXEC_MJ_SKIPOUTER_ADVANCE: advance over an outer tuple that is * known not to join to any inner tuple. * * Before advancing, we check to see if we must emit an @@ -1261,7 +1261,7 @@ ExecMergeJoin(PlanState *pstate) break; /* - * SKIPINNER_ADVANCE: advance over an inner tuple that is + * EXEC_MJ_SKIPINNER_ADVANCE: advance over an inner tuple that is * known not to join to any outer tuple. * * Before advancing, we check to see if we must emit an ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: doc: join state for merge join 2022-02-19 13:20 doc: join state for merge join Zhihong Yu <[email protected]> @ 2022-02-19 19:24 ` Daniel Gustafsson <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2022-02-19 19:24 UTC (permalink / raw) To: Zhihong Yu <[email protected]>; +Cc: PostgreSQL Developers <[email protected]> > On 19 Feb 2022, at 14:20, Zhihong Yu <[email protected]> wrote: > When i was looking at the code for ExecMergeJoin(), I noticed a few places where the join state name in the comment doesn't match the actual state. Given the comments on the other states, I'm bound to agree. Unless there are objections I'll go ahead with this one. -- Daniel Gustafsson https://vmware.com/ ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-02-19 19:24 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-01-23 23:17 [PATCH 13/18] doc review for FDW bulk inserts Justin Pryzby <[email protected]> 2022-02-19 13:20 doc: join state for merge join Zhihong Yu <[email protected]> 2022-02-19 19:24 ` Re: doc: join state for merge join Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox