From: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
To: Jacob Champion <jchampion@timescale.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: RE: Improve logging when using Huge Pages
Date: Wed, 3 Aug 2022 08:42:01 +0000
Message-ID: <DM4PR84MB1734812E1690CD7BEB4B9C57EE9C9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <d0a35f68-5d13-306c-f589-0ce816e952a5@timescale.com>
References: <TU4PR8401MB1152B1A4158D609472ABD51DEEA09@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
<80872660-ad16-3040-0a25-bd741faa5fc0@oss.nttdata.com>
<20210922002322.GS831@telsasoft.com>
<20210927.114023.1519840069762071193.horikyota.ntt@gmail.com>
<TU4PR8401MB11529A0C57CEDCCBC39050EDEEA79@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
<20211022023815.GI741@telsasoft.com>
<TU4PR8401MB11529CCEE0FCC07EEE9F8FA7EE859@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
<20211028220534.GB31568@telsasoft.com>
<d928cc86-8e03-b481-18f7-2cb9c28fc724@oss.nttdata.com>
<CAD21AoDrEma7ZGid2siYMDSa559O3Ox+N_D2B6vGwN5opqYr1w@mail.gmail.com>
<TU4PR8401MB1152ECB9368A5CCC9AB0835DEE9F9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
<d0a35f68-5d13-306c-f589-0ce816e952a5@timescale.com>
Hello,
> As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest.
Thank you for your helpful comments.
As you say, my patch doesn't seem to be of much interest to reviewers either.
I will discard the patch I proposed this time and consider it again.
Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Jacob Champion <jchampion@timescale.com>
Sent: Tuesday, August 2, 2022 5:45 AM
To: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>; Masahiko Sawada <sawada.mshk@gmail.com>; Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>; PostgreSQL-development <pgsql-hackers@postgresql.org>; Julien Rouhaud <rjuju123@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: Improve logging when using Huge Pages
As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest.
This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in that there's probably not much actionable feedback at all. Rather than code changes, what this patch needs is more community interest. You might
- ask people for help with your approach,
- see if there are similar patches that your code could supplement,
- get interested parties to agree to review your patch in a CF, or
- possibly present the functionality in a way that's easier to review
overall.
(Doing these things is no guarantee that there will be interest, but it's hopefully better than endlessly rebasing a patchset that is not receiving any feedback from the community.)
Once you think you've built up some community support and the patchset is ready for review, you (or any interested party) can resurrect the patch entry by visiting
https://commitfest.postgresql.org/38/3310/
and changing the status to "Needs Review", and then changing the status again to "Move to next CF". (Don't forget the second step; hopefully we will have streamlined this in the near future!)
Thanks,
--Jacob
[1] https://postgr.es/m/86140760-8ba5-6f3a-3e6e-5ca6c060bd24@timescale.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noriyoshi.shinoda@hpe.com, jchampion@timescale.com, sawada.mshk@gmail.com, masao.fujii@oss.nttdata.com, pryzby@telsasoft.com, rjuju123@gmail.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com
Subject: RE: Improve logging when using Huge Pages
In-Reply-To: <DM4PR84MB1734812E1690CD7BEB4B9C57EE9C9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox