From: Chao Li <li.evan.chao@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: postgresql.conf.sample tab width
Date: Tue, 18 Nov 2025 10:25:38 +0800
Message-ID: <EE0918D4-F05C-4047-910C-F0DED136ADE7@gmail.com> (raw)
In-Reply-To: <aRtugij0CQTbpmIx@nathan>
References: <aReNUKdMgKxLqmq7@nathan>
<3230808.1763151915@sss.pgh.pa.us>
<aRefX8JOs_3VbErE@nathan>
<3238135.1763156048@sss.pgh.pa.us>
<aRehOVyEMFIxl5rE@nathan>
<aRtugij0CQTbpmIx@nathan>
Hi Nathan,
I just reviewed the patch. Looks to me the correct three-commit split:
0001 updates tooling/configure so that 0002 will not introduce formatting violation
0002 makes large formatting rewrite (tab->white spaces), and so that the commit needs to be added to .git-blace-ignore-revs
0003 adds CI enforcement so that no future patches to reintroduce tabs
A tiny comment about a typo in 0003’s commit message:
```
The previous commit updated this file to use tabs instead of
spaces.
```
Should be “use spaces instead of tabs”.
> On Nov 18, 2025, at 02:50, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> Here is a rebased patch set. Notably, I've split it into three pieces.
> I'm planning to add 0002 to .git-blame-ignore-revs, as testing indicates
> this preserves the blame history reasonably well.
>
> --
> nathan
> <v3-0001-Update-.editorconfig-and-.gitattributes-for-postg.patch><v3-0002-Switch-from-tabs-to-spaces-in-postgresql.conf.sam.patch><v3-0003-Check-for-tabs-in-postgresql.conf.sample.patch>
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: li.evan.chao@gmail.com, nathandbossart@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: postgresql.conf.sample tab width
In-Reply-To: <EE0918D4-F05C-4047-910C-F0DED136ADE7@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox