From: Chao Li <li.evan.chao@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: Rename of varatt_external to varatt_external_oid
Date: Fri, 4 Sep 2026 14:20:48 +0800
Message-ID: <FBE0E804-F1F5-4AD5-8A46-445F26B097A7@gmail.com> (raw)
In-Reply-To: <apoc0WqBlSeBHIMg@paquier.xyz>
References: <apoD1Ulet2PtDrRV@paquier.xyz>
<1B63EFC9-93D5-4197-8D12-181D8F55ACA5@gmail.com>
<apoc0WqBlSeBHIMg@paquier.xyz>
> On Sep 4, 2026, at 09:20, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Sep 04, 2026 at 08:43:37AM +0800, Chao Li wrote:
>> I tried to review this patch, but “git am” failed on the current
>> HEAD (2b3d11aaed8). Would you please rebase?
>
> Oops. Sorry for the incorrect rebase blurp caused by 2b3d11aaed89.
> The attached should work better.
> --
> Michael
> <v2-0001-Rename-varatt_external-to-varatt_external_oid.patch>
I briefly went through the referenced patch as well as Tom’s comment, so I have no objection to this renaming.
The code changes in v2 look good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: li.evan.chao@gmail.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us, andres@anarazel.de
Subject: Re: Rename of varatt_external to varatt_external_oid
In-Reply-To: <FBE0E804-F1F5-4AD5-8A46-445F26B097A7@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox