pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bossart, Nathan <bossartn@amazon.com>
To: Robert Haas <robertmhaas@gmail.com>
To: Amul Sul <sulamul@gmail.com>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: Rushabh Lathia <rushabh.lathia@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Prabhat Sahu <prabhat.sahu@enterprisedb.com>
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Date: Mon, 25 Oct 2021 19:14:44 +0000
Message-ID: <FECEE7FC-CB74-45A9-BB24-89FEE52A9585@amazon.com> (raw)
In-Reply-To: <CA+TgmoZrtgZCTA++wOS+=nXGPhrp6965EZorpRfyvyEpFfdWiQ@mail.gmail.com>
References: <CAAJ_b97vxaTA-GZK4AyCJvrpzUsAhGLugXaYrE7mybb4FmOarw@mail.gmail.com>
	<CA+TgmoaPDkcNViu+jtgicBQ2WbHt5J_1P98Zq_00RUwDP5rwiQ@mail.gmail.com>
	<CA+TgmoYaMXTFV02rb-jyPshwAQV=5GLKX02-u-g6L+sJttXxVQ@mail.gmail.com>
	<CAAJ_b96G-oBxDC3C7Y72ER09bsheGHOxBK1HXHVOyHNXjTDmcA@mail.gmail.com>
	<CA+TgmoaScsuDcTYa_-pkBnVP5Xcb_vx0BX2qn6grnTt=+mmH6g@mail.gmail.com>
	<CAAJ_b96KcmmJw6rTEX_br485VYL1MAv89pJ31znctN8e6ri_cQ@mail.gmail.com>
	<CAAJ_b94WUtC2MU5EnDmx-Mhuw1xoN5xyHABbjJzoStP6DHsp9g@mail.gmail.com>
	<CA+Tgmob8zNB_pMr9X6=5syYYeAc9hUtZmZGRLOzW=Oyud3ho0A@mail.gmail.com>
	<CAGPqQf2n0aeeKMv+mA0zpgkqkamEVMCZE_VL74hxCe9hSNOQNg@mail.gmail.com>
	<CAAJ_b9549-u2qo4hgGcE94vcv6sTHUO_Eq+5vB1_-Av5QokJLw@mail.gmail.com>
	<20211007002651.GA20716@ahch-to>
	<CAAJ_b952yF_qZL0s1_dpr9HL0MVt1xp9J02px23aThLKrR7KPg@mail.gmail.com>
	<CAAJ_b97abMuq=470Wahun=aS1PHTSbStHtrjjPaD-C0YQ1AqVw@mail.gmail.com>
	<CA+TgmobppXiL598ytRivAX6-MoRxDxNV4np1h+ybbJdxf2uxgw@mail.gmail.com>
	<CAAJ_b94KNpGXzeEuSHTvrMzkRP0Vp-uveTG604GS_up+paPfbQ@mail.gmail.com>
	<CA+TgmoZ5A26C6OxKApafyuy_sx0VG6VXdD_Q6aSEzsvrPHDwzw@mail.gmail.com>
	<CAAJ_b97fysj6sRSQEfOHj-y8Jfd5uPqOgO74qast89B4WfD+TA@mail.gmail.com>
	<CA+TgmoZrtgZCTA++wOS+=nXGPhrp6965EZorpRfyvyEpFfdWiQ@mail.gmail.com>

On 10/25/21, 7:50 AM, "Robert Haas" <robertmhaas@gmail.com> wrote:
> I've pushed 0001 and 0002 but I reversed the order of them and made a
> few other edits.

My compiler is complaining about oldXLogAllowed possibly being used
uninitialized in CreateCheckPoint().  AFAICT it can just be initially
set to zero to silence this warning because it will, in fact, be
initialized properly when it is used.

Nathan



view thread (197+ messages)  latest in thread

Message-ID: <FECEE7FC-CB74-45A9-BB24-89FEE52A9585@amazon.com>
Permalink:  ../FECEE7FC-CB74-45A9-BB24-89FEE52A9585@amazon.com/
Also on:    postgresql.org/message-id/FECEE7FC-CB74-45A9-BB24-89FEE52A9585@amazon.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bossartn@amazon.com, robertmhaas@gmail.com, sulamul@gmail.com, jcasanov@systemguards.com.ec, rushabh.lathia@gmail.com, dilipbalaut@gmail.com, andres@anarazel.de, bharath.rupireddyforpostgres@gmail.com, ibrar.ahmad@gmail.com, prabhat.sahu@enterprisedb.com
  Subject: Re: [Patch] ALTER SYSTEM READ ONLY
  In-Reply-To: <FECEE7FC-CB74-45A9-BB24-89FEE52A9585@amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox