From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Bruce Momjian <bruce@momjian.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: doc review for v14
Date: Sun, 3 Jan 2021 21:05:09 +0900
Message-ID: <X/Gy9WIbyS3rnLyx@paquier.xyz> (raw)
In-Reply-To: <20210103063354.GI25152@telsasoft.com>
References: <20201222041153.GK30237@telsasoft.com>
<X+RNUu+zotOjfL7K@paquier.xyz>
<20201227202604.GC26311@telsasoft.com>
<X+r1YyXWE5obOazQ@paquier.xyz>
<X/Ff7jfnvJUab013@paquier.xyz>
<20210103063354.GI25152@telsasoft.com>
On Sun, Jan 03, 2021 at 12:33:54AM -0600, Justin Pryzby wrote:
>
> But actually, maybe we should just use the comment that exists everywhere else
> for that.
>
> /* Propagate context related error context to libxml2 */
> xmlSetStructuredErrorFunc((void *) xtCxt->xmlerrcxt, xml_errorHandler);
I quite like your suggestion to be a maximum simple here, and the docs
of upstream also give a lot of context:
http://xmlsoft.org/html/libxml-xmlerror.html#xmlSetStructuredErrorFunc
So let's use this version and call it a day for this part.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../X%2FGy9WIbyS3rnLyx@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, pryzby@telsasoft.com, bruce@momjian.us, thomas.munro@gmail.com
Subject: Re: doc review for v14
In-Reply-To: <X/Gy9WIbyS3rnLyx@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox