pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Joe Conway <mail@joeconway.com>
Cc: Joshua Brindle <joshua.brindle@crunchydata.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: use has_privs_of_role() for pg_hba.conf
Date: Sun, 9 Oct 2022 10:19:51 +0900
Message-ID: <Y0Iht953YoGpCXeb@paquier.xyz> (raw)
In-Reply-To: <20221008171222.GB825354@nathanxps13>
References: <20221007032711.GA499771@nathanxps13>
	<Yz/Ii6dr1CSu4Bnv@paquier.xyz>
	<20221007194430.GA550749@nathanxps13>
	<3347532.1665173939@sss.pgh.pa.us>
	<20221007215836.GB814385@nathanxps13>
	<87994809-5b2c-08f0-0ab3-3c76c49afada@joeconway.com>
	<3574712.1665242046@sss.pgh.pa.us>
	<CA+TgmoYDUpotJ3R5cPWqKZpi7TmTRq2ud4OYsvWnvPYK0KmaAQ@mail.gmail.com>
	<CAKFQuwbbR==cUhGpv0+G=z1mgKS+8ysdtMqSgt4mMvGwAyYYQg@mail.gmail.com>
	<20221008171222.GB825354@nathanxps13>

On Sat, Oct 08, 2022 at 10:12:22AM -0700, Nathan Bossart wrote:
> Okay, I think there are sufficient votes against this change to simply mark
> it Rejected.  Thanks for the discussion!

Even if the patch is at the end rejected, I think that the test is
still useful once you switch its logic to use membership and not
inherited privileges for the roles created, and there is zero coverage
for "samplegroup" and its kind currently.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (25+ messages)  latest in thread

Message-ID: <Y0Iht953YoGpCXeb@paquier.xyz>
Permalink:  ../Y0Iht953YoGpCXeb@paquier.xyz/
Also on:    postgresql.org/message-id/Y0Iht953YoGpCXeb@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, nathandbossart@gmail.com, david.g.johnston@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, mail@joeconway.com, joshua.brindle@crunchydata.com
  Subject: Re: use has_privs_of_role() for pg_hba.conf
  In-Reply-To: <Y0Iht953YoGpCXeb@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox