pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Drouvot, Bertrand <bdrouvot@amazon.com>
Subject: Re: Generating code for query jumbling through gen_node_support.pl
Date: Thu, 19 Jan 2023 17:46:37 +0900
Message-ID: <Y8kDbQluozdea/Oo@paquier.xyz> (raw)
In-Reply-To: <50b571dc-e0c0-22be-9803-4a3480d2e792@enterprisedb.com>
References: <Y5BHOUhX3zTH/ig6@paquier.xyz>
	<34491a4e-2664-6ea7-662c-b13d18d2a92d@enterprisedb.com>
	<Y8EOUuViEL8Ewvf/@paquier.xyz>
	<d74d2681-5c07-2f6e-d177-995905015311@enterprisedb.com>
	<Y8YakMwx2a6Y63oR@paquier.xyz>
	<e4801c28-cb5b-3b81-bda1-03af8df1fef9@enterprisedb.com>
	<Y8ZTvD6nEqNttAHJ@paquier.xyz>
	<Y8eZ9/3STyhF57RV@paquier.xyz>
	<50b571dc-e0c0-22be-9803-4a3480d2e792@enterprisedb.com>

On Thu, Jan 19, 2023 at 09:42:03AM +0100, Peter Eisentraut wrote:
> I see that in the 0003 patch, most location fields now have an explicit
> markup with query_jumble_ignore.  I thought we had previously resolved to
> consider location fields to be automatically ignored unless explicitly
> included (like for the Const node).  This appears to invert that?  Am I
> missing something?

My misunderstanding then, I thought that you were OK with what was
part of v1, where all these fields was marked as "ignore".  But you
actually prefer v2, with the second field "location" on top of
"ignore".  I can update 0003 to refresh that.

Would you be OK if I apply 0001 (with the comments of the locations
still reshaped to ease future property additions) and 0002?
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (44+ messages)  latest in thread

Message-ID: <Y8kDbQluozdea/Oo@paquier.xyz>
Permalink:  ../Y8kDbQluozdea%2FOo@paquier.xyz/
Also on:    postgresql.org/message-id/Y8kDbQluozdea/Oo@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org, bdrouvot@amazon.com
  Subject: Re: Generating code for query jumbling through gen_node_support.pl
  In-Reply-To: <Y8kDbQluozdea/Oo@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox