From: Michael Paquier <michael@paquier.xyz>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Euler Taveira <euler.taveira@2ndquadrant.com>
Cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: cleanup temporary files after crash
Date: Tue, 9 Mar 2021 21:31:16 +0900
Message-ID: <YEdqlL3Gr3rZ/aC8@paquier.xyz> (raw)
In-Reply-To: <363cb85c-3a03-9a49-b830-8b645c1241d9@enterprisedb.com>
References: <CAH503wDKdYzyq7U-QJqGn=Gm6XmoK+6_6xTJ-Yn5WSvoHLY1Ww@mail.gmail.com>
<20201028184252.5vpoe65kcfebbmmf@development>
<CAH503wCg+yne7hKAAFFHsVPe+tPb-aF5VGaWG0ETqyB3GP=Q+g@mail.gmail.com>
<20201101012555.GC3000@paquier.xyz>
<1982ee3c-54c3-280a-806a-fd28ad8f19e6@postgrespro.ru>
<CAH503wBLgLGhqCduqzOBgCYNS5DiJnUJdU+RVCCQoka8Tndndg@mail.gmail.com>
<363cb85c-3a03-9a49-b830-8b645c1241d9@enterprisedb.com>
On Tue, Mar 09, 2021 at 02:28:43AM +0100, Tomas Vondra wrote:
> Let's move this patch forward. Based on the responses, I agree the
> default behavior should be to remove the temp files, and I think we
> should have the GUC (on the off chance that someone wants to preserve
> the temporary files for debugging or whatever other reason).
Thanks for taking care of this. I am having some second-thoughts
about changing this behavior by default, still that's much more useful
this way.
> I propose to rename the GUC to remove_temp_files_after_crash, I think
> "remove" is a bit clearer than "cleanup". I've also reworded the sgml
> docs a little bit.
"remove" sounds fine to me.
> Attached is a patch with those changes. Barring objections, I'll get
> this committed in the next couple days.
+ When set to on, <productname>PostgreSQL</productname> will automatically
Nit: using a <literal> markup for the "on" value.
+#remove_temp_files_after_crash = on # remove temporary files after
+# # backend crash?
The indentation of the second line is incorrect here (Incorrect number
of spaces in tabs perhaps?), and there is no need for the '#' at the
beginning of the line.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tomas.vondra@enterprisedb.com, euler.taveira@2ndquadrant.com, a.lubennikova@postgrespro.ru, tomas.vondra@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us
Subject: Re: cleanup temporary files after crash
In-Reply-To: <YEdqlL3Gr3rZ/aC8@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox