pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Jacob Champion <pchampion@vmware.com>
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Date: Thu, 6 May 2021 21:04:57 +0900
Message-ID: <YJPbaYkIWeSbNF65@paquier.xyz> (raw)
In-Reply-To: <CAFiTN-vH84fE-8C4zGZw4v0Wyh4Y2v=5JWg2fGE5+LPaDvz1GQ@mail.gmail.com>
References: <YIetoZGq31L84v5d@paquier.xyz>
	<CA+Tgmob9h5u4iNL9KM0drZgkY-JL4oCVW0dWrMqtLPQ1zHkquA@mail.gmail.com>
	<CAFiTN-sQ5XpB5dVn2-FMBG+20f7HYky9kgCy8rVAT_cP3mkvEg@mail.gmail.com>
	<CAFiTN-vWpFjgzQnhbuvJvRm09rnpcttH=rqXQw=o2xyybfgOVA@mail.gmail.com>
	<YJJz1bbvBXyzEG68@paquier.xyz>
	<CAFiTN-v-P1zAS+r0AGv148EY=hhLCQh4RAN318OWT=Hwa=WwAQ@mail.gmail.com>
	<CA+TgmoavG0eN8UdWFwjKEH9LfoYsGzpQxnhPaegnwuAp5d=PHw@mail.gmail.com>
	<YJMyr0feaqIuqJQz@paquier.xyz>
	<CAFiTN-s2Pm901O6sHy4scr6kNMgWHQ6_n7+BtKmdK+4fkYzMiQ@mail.gmail.com>
	<CAFiTN-vH84fE-8C4zGZw4v0Wyh4Y2v=5JWg2fGE5+LPaDvz1GQ@mail.gmail.com>

On Thu, May 06, 2021 at 05:01:23PM +0530, Dilip Kumar wrote:
> I noticed that the error code for invalid compression method is not
> perfect, basically when we pass the invalid compression method during
> CREATE/ALTER table that time we give
> ERRCODE_FEATURE_NOT_SUPPORTED.  I think the correct error code is
> ERRCODE_INVALID_PARAMETER_VALUE.  I have attached a patch to fix this.

Yeah, I agree that this is an improvement, so let's fix this.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (28+ messages)  latest in thread

Message-ID: <YJPbaYkIWeSbNF65@paquier.xyz>
Permalink:  ../YJPbaYkIWeSbNF65@paquier.xyz/
Also on:    postgresql.org/message-id/YJPbaYkIWeSbNF65@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, dilipbalaut@gmail.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org, pchampion@vmware.com
  Subject: Re: Small issues with CREATE TABLE COMPRESSION
  In-Reply-To: <YJPbaYkIWeSbNF65@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox