pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Jacob Champion <pchampion@vmware.com>
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Date: Thu, 6 May 2021 21:12:37 +0900
Message-ID: <YJPdNeF68XpwDDki@paquier.xyz> (raw)
In-Reply-To: <CAFiTN-s2Pm901O6sHy4scr6kNMgWHQ6_n7+BtKmdK+4fkYzMiQ@mail.gmail.com>
References: <YIetoZGq31L84v5d@paquier.xyz>
	<CA+Tgmob9h5u4iNL9KM0drZgkY-JL4oCVW0dWrMqtLPQ1zHkquA@mail.gmail.com>
	<CAFiTN-sQ5XpB5dVn2-FMBG+20f7HYky9kgCy8rVAT_cP3mkvEg@mail.gmail.com>
	<CAFiTN-vWpFjgzQnhbuvJvRm09rnpcttH=rqXQw=o2xyybfgOVA@mail.gmail.com>
	<YJJz1bbvBXyzEG68@paquier.xyz>
	<CAFiTN-v-P1zAS+r0AGv148EY=hhLCQh4RAN318OWT=Hwa=WwAQ@mail.gmail.com>
	<CA+TgmoavG0eN8UdWFwjKEH9LfoYsGzpQxnhPaegnwuAp5d=PHw@mail.gmail.com>
	<YJMyr0feaqIuqJQz@paquier.xyz>
	<CAFiTN-s2Pm901O6sHy4scr6kNMgWHQ6_n7+BtKmdK+4fkYzMiQ@mail.gmail.com>

On Thu, May 06, 2021 at 10:45:53AM +0530, Dilip Kumar wrote:
> Thanks, Robert and Michael for your input.  I will try to understand
> how it is done in the example shared by you and come up with the test
> once I get time.  I assume this is not something urgent.

Thanks.  FWIW, I'd rather see this gap closed asap, as features should
come with proper tests IMO.

While on it, I can see that there is no support for --with-lz4 in the
MSVC scripts.  I think that this is something where we had better
close the gap, and upstream provides binaries on Windows on their
release page:
https://github.com/lz4/lz4/releases

And I am familiar with both areas, so I have no helping out and
getting that in shape correctly before beta1.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (28+ messages)  latest in thread

Message-ID: <YJPdNeF68XpwDDki@paquier.xyz>
Permalink:  ../YJPdNeF68XpwDDki@paquier.xyz/
Also on:    postgresql.org/message-id/YJPdNeF68XpwDDki@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, dilipbalaut@gmail.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org, pchampion@vmware.com
  Subject: Re: Small issues with CREATE TABLE COMPRESSION
  In-Reply-To: <YJPdNeF68XpwDDki@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox