pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Jacob Champion <pchampion@vmware.com>
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Date: Mon, 10 May 2021 09:36:24 +0900
Message-ID: <YJiACGuD32s9f7sV@paquier.xyz> (raw)
In-Reply-To: <20210508140618.GA10189@telsasoft.com>
References: <CAFiTN-v-P1zAS+r0AGv148EY=hhLCQh4RAN318OWT=Hwa=WwAQ@mail.gmail.com>
	<CA+TgmoavG0eN8UdWFwjKEH9LfoYsGzpQxnhPaegnwuAp5d=PHw@mail.gmail.com>
	<YJMyr0feaqIuqJQz@paquier.xyz>
	<CAFiTN-s2Pm901O6sHy4scr6kNMgWHQ6_n7+BtKmdK+4fkYzMiQ@mail.gmail.com>
	<YJPdNeF68XpwDDki@paquier.xyz>
	<CAFiTN-sb-hA9=85Hac9J7oY9B=4DE=fPinF=oKTL-QW7eQV1Hw@mail.gmail.com>
	<YJZN5up79UvHuLWp@paquier.xyz>
	<YJaOZQDXBVySq+Cc@paquier.xyz>
	<20210508132239.GX27406@telsasoft.com>
	<20210508140618.GA10189@telsasoft.com>

On Sat, May 08, 2021 at 09:06:18AM -0500, Justin Pryzby wrote:
> I suggest that should reference guc-default-toast-compression instead of CREATE
> TABLE, since CREATE TABLE is large and very non-specific.

Yes, that's a better idea.

> Also, in at least 3 places there's extraneous trailing whitespace.
> Two of these should (I think) be a blank line.

Fixed these, and applied this doc patch as a first piece.  Thanks for
the review.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (28+ messages)  latest in thread

Message-ID: <YJiACGuD32s9f7sV@paquier.xyz>
Permalink:  ../YJiACGuD32s9f7sV@paquier.xyz/
Also on:    postgresql.org/message-id/YJiACGuD32s9f7sV@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, pryzby@telsasoft.com, dilipbalaut@gmail.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org, pchampion@vmware.com
  Subject: Re: Small issues with CREATE TABLE COMPRESSION
  In-Reply-To: <YJiACGuD32s9f7sV@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox