pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date: Mon, 24 May 2021 17:53:51 +0900
Message-ID: <YKtpZI4PBpVG3ryH@paquier.xyz> (raw)
In-Reply-To: <CAFiTN-uLQCRLatapZhEaNGH9njY=LndyXJux7H9YCfT9RcE7gA@mail.gmail.com>
References: <20210517204803.iyk5wwvwgtjcmc5w@alap3.anarazel.de>
	<2854987.1621285592@sss.pgh.pa.us>
	<20210517212857.qyk4fxykfbxhmxof@alap3.anarazel.de>
	<YKMXVHCoNGZ61E9q@paquier.xyz>
	<YKdT5ZM5OInCsDkM@paquier.xyz>
	<3962395.1621609263@sss.pgh.pa.us>
	<20210521211929.pcehg6f23icwstdb@alap3.anarazel.de>
	<YKsm7qkz+Cq3C3mr@paquier.xyz>
	<CAFiTN-uLQCRLatapZhEaNGH9njY=LndyXJux7H9YCfT9RcE7gA@mail.gmail.com>

On Mon, May 24, 2021 at 11:32:22AM +0530, Dilip Kumar wrote:
> I think you don't need to initialize tup_values[i] with the
> values[i];, other than that looks fine to me.

You mean because heap_deform_tuple() does this job, right?  Sure.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (73+ messages)  latest in thread

Message-ID: <YKtpZI4PBpVG3ryH@paquier.xyz>
Permalink:  ../YKtpZI4PBpVG3ryH@paquier.xyz/
Also on:    postgresql.org/message-id/YKtpZI4PBpVG3ryH@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, dilipbalaut@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
  Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
  In-Reply-To: <YKtpZI4PBpVG3ryH@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox