pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Ashwin Agrawal <aagrawal@pivotal.io>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: alter table set TABLE ACCESS METHOD
Date: Thu, 10 Jun 2021 11:02:04 +0900
Message-ID: <YMFynNmWfxUScsXu@paquier.xyz> (raw)
In-Reply-To: <CALNJ-vQV32U7QpXWMbuHHxhB1eEBaPgZtvWGVbiwubRpO-AFKg@mail.gmail.com>
References: <35333ea26e52252174515e14671a9fbc1c20c8fa.camel@j-davis.com>
	<20210506202305.GQ27406@telsasoft.com>
	<1033d6b4b5b42a014cc3f617265ae6e61cb5781b.camel@j-davis.com>
	<20210506221943.GS27406@telsasoft.com>
	<3bee08c2ca0fab15d14899afcb19490f29e0ec6f.camel@j-davis.com>
	<803b32e45baf0b05e5f3fc144383db3a18081693.camel@j-davis.com>
	<27c94b85d966351e2715cdbf79cb4c658b3cfaa7.camel@j-davis.com>
	<YMBH1nt8XXi8l7NY@paquier.xyz>
	<d47f55de936b6808e5d5e3177b410d1e0909faa1.camel@j-davis.com>
	<CALNJ-vQV32U7QpXWMbuHHxhB1eEBaPgZtvWGVbiwubRpO-AFKg@mail.gmail.com>

On Wed, Jun 09, 2021 at 01:45:52PM -0700, Zhihong Yu wrote:
> +           /* check if another access method change was already requested
> */
> +           if (tab->newAccessMethod)
> +               ereport(ERROR,
> +                       (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> +                        errmsg("cannot change access method setting
> twice")));
> 
> I think the error message can be refined - changing  access method twice is
> supported, as long as the two changes don't overlap.

Hmm.  Do we actually need this one?  ATPrepSetAccessMethod() checks
already that this command cannot be specified multiple times, with an
error message consistent with what SET TABLESPACE does.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (41+ messages)  latest in thread

Message-ID: <YMFynNmWfxUScsXu@paquier.xyz>
Permalink:  ../YMFynNmWfxUScsXu@paquier.xyz/
Also on:    postgresql.org/message-id/YMFynNmWfxUScsXu@paquier.xyz

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, zyu@yugabyte.com, pgsql@j-davis.com, pryzby@telsasoft.com, pchampion@vmware.com, hlinnaka@iki.fi, aagrawal@pivotal.io, ashu.coek88@gmail.com, andres@anarazel.de, robertmhaas@gmail.com, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org, dilipbalaut@gmail.com
  Subject: Re: alter table set TABLE ACCESS METHOD
  In-Reply-To: <YMFynNmWfxUScsXu@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox