pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: gkokolatos@pm.me
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Teach pg_receivewal to use lz4 compression
Date: Fri, 2 Jul 2021 10:10:16 +0900
Message-ID: <YN5nePsQJhMLhznM@paquier.xyz> (raw)
In-Reply-To: <S2rA_l89FgB0CtpkaBoPe0DTjvkvo46zUzlZxilMGzlDCICb5rwmrKXg1bzpp5ZO75GF-b7ayvG9dihbzRwOKVawLLreJbWWGfY6OdhSpho=@pm.me>
References: <ZCm1J5vfyQ2E6dYvXz8si39HQ2gwxSZ3IpYaVgYa3lUwY88SLapx9EEnOf5uEwrddhx2twG7zYKjVeuP5MwZXCNPybtsGouDsAD1o2L_I5E=@pm.me>
	<CAFiTN-urjKKCwu+YA5VYLG40_RLst-B=BxZNKXGpuTgh8hoFtA@mail.gmail.com>
	<CABUevEyTDC1uEbF2PccLdA6hVGuqFuYemYimrBToLupu2usmjw@mail.gmail.com>
	<A6gxTGqoplZLSOzN0MS2zsutUZdFFEMhWmcrcb9MLvJ3MJ_ylD4X-g0iqHW9cB6D-dTAgf4Ep1aQoZ9UuFf9k3DBI2gZoYmZk_BFBFX2_ow=@pm.me>
	<CABUevEzuc02iacteSq78A7ws6gP7k7TSSG4FHum6uBq8+xTNig@mail.gmail.com>
	<S2rA_l89FgB0CtpkaBoPe0DTjvkvo46zUzlZxilMGzlDCICb5rwmrKXg1bzpp5ZO75GF-b7ayvG9dihbzRwOKVawLLreJbWWGfY6OdhSpho=@pm.me>

On Thu, Jul 01, 2021 at 02:10:17PM +0000, gkokolatos@pm.me wrote:
> Micheal suggested on the same thread to move my entry in the help output so that
> the output remains ordered. I would like the options for the compression method and
> the already existing compression level to next to each other if possible. Then it
> should be either 'X' or 'Y'.

Hmm.  Grouping these together makes sense for the user.  One choice
that we have here is to drop the short option, and just use a long
one.  What I think is important for the user when it comes to this
option is the consistency of its naming across all the tools
supporting it.  pg_dump and pg_basebackup, where we could plug LZ4,
already use most of the short options you could use for pg_receivewal,
having only a long one gives a bit more flexibility. 
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (55+ messages)  latest in thread

Message-ID: <YN5nePsQJhMLhznM@paquier.xyz>
Permalink:  ../YN5nePsQJhMLhznM@paquier.xyz/
Also on:    postgresql.org/message-id/YN5nePsQJhMLhznM@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, gkokolatos@pm.me, magnus@hagander.net, dilipbalaut@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Teach pg_receivewal to use lz4 compression
  In-Reply-To: <YN5nePsQJhMLhznM@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox