From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Mon, 28 Jun 2021 16:52:12 +0900
Message-ID: <YNl/rGAtp0Ovmtis@paquier.xyz> (raw)
In-Reply-To: <3128896.1624742969@sss.pgh.pa.us>
References: <3128896.1624742969@sss.pgh.pa.us>
On Sat, Jun 26, 2021 at 05:29:29PM -0400, Tom Lane wrote:
> I'll stick this into the CF list to see if the cfbot agrees that
> it finds the abort() problems...
The CF Bot is finding those problems.
> +# Check for functions that libpq must not call.
> +# (If nm doesn't exist or doesn't work on shlibs, this test will silently
> +# do nothing, which is fine.)
> +.PHONY: check-libpq-refs
> +check-libpq-refs: $(shlib)
> + @! nm -A -g -u $< 2>/dev/null | grep -e abort -e exit
"abort" and "exit" could be generic terms present in some other
libraries. Could be be better to match with "U abort" and "U exit"
instead? MinGW has a nm command, and it has a compatible option set,
so I think that it should work.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pchampion@vmware.com, daniel@yesql.se
Subject: Re: Preventing abort() and exit() calls in libpq
In-Reply-To: <YNl/rGAtp0Ovmtis@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox