From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hans Buschmann <buschmann@nidsa.net>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode
Date: Thu, 19 Aug 2021 12:29:44 +0900
Message-ID: <YR3QKNmP4EFxcRHc@paquier.xyz> (raw)
In-Reply-To: <YRxQ1sN5ceWPgwdM@paquier.xyz>
References: <1629039545467.80333@nidsa.net>
<YRsYT3Fb82IYr5+F@paquier.xyz>
<1075837.1629207570@sss.pgh.pa.us>
<YRxQ1sN5ceWPgwdM@paquier.xyz>
On Wed, Aug 18, 2021 at 09:14:14AM +0900, Michael Paquier wrote:
> Sure. aef8948 gets down because of the performance impact. ccf4e27
> was a cleanup following up aef8948, that loses its meaning. And
> c3826f8 cannot be let alone because of the reasons why aef8948 was
> introduced, as it has no safety net for out-of-bound handling in the
> result buffer allocated.
And done, with such a description in the commit log.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, buschmann@nidsa.net
Subject: Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode
In-Reply-To: <YR3QKNmP4EFxcRHc@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox