public inbox for [email protected]help / color / mirror / Atom feed
typos 10+ messages / 3 participants [nested] [flat]
* typos @ 2021-09-24 21:58 Justin Pryzby <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Justin Pryzby @ 2021-09-24 21:58 UTC (permalink / raw) To: pgsql-hackers A compilation of fixes for master. The first patch should be applied to v13 - the typo was already fixed in master but not backpatched. ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-26 17:01 Justin Pryzby <[email protected]> parent: Justin Pryzby <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Justin Pryzby @ 2021-09-26 17:01 UTC (permalink / raw) To: pgsql-hackers; +Cc: Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On Fri, Sep 24, 2021 at 04:58:27PM -0500, Justin Pryzby wrote: > A compilation of fixes for master. Thanks Michael for applying fixes to user-facing docs (I hadn't realized that the 2nd one needed to be backpatched). This fixes an file I failed to include in the "recheck" patch and more typos for extended stats (+Tomas). +Andres (Jit), +Zhihong (file header comments). ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-27 00:24 Michael Paquier <[email protected]> parent: Justin Pryzby <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Michael Paquier @ 2021-09-27 00:24 UTC (permalink / raw) To: Justin Pryzby <[email protected]>; +Cc: pgsql-hackers; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On Sun, Sep 26, 2021 at 12:01:17PM -0500, Justin Pryzby wrote: > Thanks Michael for applying fixes to user-facing docs (I hadn't realized that > the 2nd one needed to be backpatched). Yes, thanks for compiling all these. The two changes committed were the only user-visible changes, which is why I have hastened this part to include those fixes. The rest could just go on HEAD. -- Michael Attachments: [application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc) download ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-27 05:23 Michael Paquier <[email protected]> parent: Michael Paquier <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Michael Paquier @ 2021-09-27 05:23 UTC (permalink / raw) To: Justin Pryzby <[email protected]>; +Cc: pgsql-hackers; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On Mon, Sep 27, 2021 at 09:24:27AM +0900, Michael Paquier wrote: > Yes, thanks for compiling all these. The two changes committed were > the only user-visible changes, which is why I have hastened this part > to include those fixes. The rest could just go on HEAD. I have looked at the full set, and applied 0003, 0006, 0009, 0010 and 0011. 0001 has been discussed separately, and I am really not sure if that's worth bothering. 0002 may actually break some code? I have let 0004 and 0005 alone. 0007 could be related to the discussion where we could just remove all those IDENTIFICATION fields. The use of "statistic", "statistics" and "statistics object" in 0008 and 0012 is indeed inconsistent. The latter term is the most used, but it sounds a bit weird to me even if it refers to the DDL object manipulated. Simply using "statistics" would be tempting. -- Michael Attachments: [application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc) download ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-27 21:04 Alvaro Herrera <[email protected]> parent: Michael Paquier <[email protected]> 0 siblings, 2 replies; 10+ messages in thread From: Alvaro Herrera @ 2021-09-27 21:04 UTC (permalink / raw) To: Michael Paquier <[email protected]>; +Cc: Justin Pryzby <[email protected]>; pgsql-hackers; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On 2021-Sep-27, Michael Paquier wrote: > The use > of "statistic", "statistics" and "statistics object" in 0008 and 0012 > is indeed inconsistent. The latter term is the most used, but it > sounds a bit weird to me even if it refers to the DDL object > manipulated. Simply using "statistics" would be tempting. Initially we just used "statistic" as a noun, which IIRC was already grammatically wrong (but I didn't know that and I think Tomas didn't either); later at some point when discussing how to use that noun in plural we realized this and argued that merely using "statistics" was even more wrong. It was then that we started using the term "statistics object" with plural "statistics objects". Going back to using just "statistics" is unlikely to have become correct; I think Justin's patches 0008 and 0012 are correct. -- Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/ "La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez) ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-27 23:53 Michael Paquier <[email protected]> parent: Alvaro Herrera <[email protected]> 1 sibling, 0 replies; 10+ messages in thread From: Michael Paquier @ 2021-09-27 23:53 UTC (permalink / raw) To: Alvaro Herrera <[email protected]>; +Cc: Justin Pryzby <[email protected]>; pgsql-hackers; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On Mon, Sep 27, 2021 at 06:04:02PM -0300, Alvaro Herrera wrote: > Initially we just used "statistic" as a noun, which IIRC was already > grammatically wrong (but I didn't know that and I think Tomas didn't > either); later at some point when discussing how to use that noun in > plural we realized this and argued that merely using "statistics" was > even more wrong. It was then that we started using the term "statistics > object" with plural "statistics objects". Going back to using just > "statistics" is unlikely to have become correct; I think Justin's > patches 0008 and 0012 are correct. Thanks for confirming. if (list_length(pstate->p_rtable) != 1) ereport(ERROR, (errcode(ERRCODE_INVALID_COLUMN_REFERENCE), - errmsg("statistics expressions can refer only to the table being indexed"))); + errmsg("statistics expressions can refer only to the table being referenced"))); This part should be backpatched? The code claims that this should be dead code so an elog() would be more adapted, and the same can be said about transformRuleStmt() and transformIndexStmt(), no? That would be less messages to translate. -- Michael Attachments: [application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc) download ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-28 00:50 Justin Pryzby <[email protected]> parent: Alvaro Herrera <[email protected]> 1 sibling, 1 reply; 10+ messages in thread From: Justin Pryzby @ 2021-09-28 00:50 UTC (permalink / raw) To: Alvaro Herrera <[email protected]>; +Cc: Michael Paquier <[email protected]>; pgsql-hackers; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On Mon, Sep 27, 2021 at 06:04:02PM -0300, Alvaro Herrera wrote: > On 2021-Sep-27, Michael Paquier wrote: > > > The use > > of "statistic", "statistics" and "statistics object" in 0008 and 0012 > > is indeed inconsistent. The latter term is the most used, but it > > sounds a bit weird to me even if it refers to the DDL object > > manipulated. Simply using "statistics" would be tempting. > > Initially we just used "statistic" as a noun, which IIRC was already > grammatically wrong (but I didn't know that and I think Tomas didn't > either); later at some point when discussing how to use that noun in > plural we realized this and argued that merely using "statistics" was > even more wrong. It was then that we started using the term "statistics > object" with plural "statistics objects". Going back to using just > "statistics" is unlikely to have become correct; I think Justin's > patches 0008 and 0012 are correct. Attached is an updated patch fixing more of the same. -- Justin ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-28 02:15 Michael Paquier <[email protected]> parent: Justin Pryzby <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Michael Paquier @ 2021-09-28 02:15 UTC (permalink / raw) To: Justin Pryzby <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; pgsql-hackers; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On Mon, Sep 27, 2021 at 07:50:02PM -0500, Justin Pryzby wrote: > Attached is an updated patch fixing more of the same. Does this include everything you have spotted, as well as everything from the previous patches 0008 and 0012 posted? -- Michael Attachments: [application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc) download ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-28 02:27 Justin Pryzby <[email protected]> parent: Michael Paquier <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Justin Pryzby @ 2021-09-28 02:27 UTC (permalink / raw) To: Michael Paquier <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; pgsql-hackers; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On Tue, Sep 28, 2021 at 11:15:39AM +0900, Michael Paquier wrote: > On Mon, Sep 27, 2021 at 07:50:02PM -0500, Justin Pryzby wrote: > > Attached is an updated patch fixing more of the same. > > Does this include everything you have spotted, as well as everything > from the previous patches 0008 and 0012 posted? That's an "expanded" version of 0008. It doesn't include 0012, which is primarily about fixing incorrect references to "index expressions" that should refer to stats expressions. Naturally 0012 also uses the phrase "statistics objects", and fixes one nearby reference that's not itself about indexes, which could arguably be in 0008 instead.. -- Justin ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: typos (and more) @ 2021-09-29 07:26 Michael Paquier <[email protected]> parent: Justin Pryzby <[email protected]> 0 siblings, 0 replies; 10+ messages in thread From: Michael Paquier @ 2021-09-29 07:26 UTC (permalink / raw) To: Justin Pryzby <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; pgsql-hackers; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Zhihong Yu <[email protected]> On Mon, Sep 27, 2021 at 09:27:56PM -0500, Justin Pryzby wrote: > That's an "expanded" version of 0008. Okay, thanks. > It doesn't include 0012, which is primarily about fixing incorrect references > to "index expressions" that should refer to stats expressions. Naturally 0012 > also uses the phrase "statistics objects", and fixes one nearby reference > that's not itself about indexes, which could arguably be in 0008 instead.. Merging both made the most sense to me after reviewing the whole area of the code dedicated to stats. This has been applied after taking care of some issues with the indentation, with few extra tweaks. -- Michael Attachments: [application/pgp-signature] signature.asc (833B, ../../YVQVQ6J%[email protected]/2-signature.asc) download ^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2021-09-29 07:26 UTC | newest] Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-24 21:58 typos Justin Pryzby <[email protected]> 2021-09-26 17:01 ` Re: typos (and more) Justin Pryzby <[email protected]> 2021-09-27 00:24 ` Re: typos (and more) Michael Paquier <[email protected]> 2021-09-27 05:23 ` Re: typos (and more) Michael Paquier <[email protected]> 2021-09-27 21:04 ` Re: typos (and more) Alvaro Herrera <[email protected]> 2021-09-27 23:53 ` Re: typos (and more) Michael Paquier <[email protected]> 2021-09-28 00:50 ` Re: typos (and more) Justin Pryzby <[email protected]> 2021-09-28 02:15 ` Re: typos (and more) Michael Paquier <[email protected]> 2021-09-28 02:27 ` Re: typos (and more) Justin Pryzby <[email protected]> 2021-09-29 07:26 ` Re: typos (and more) Michael Paquier <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox