pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Georgios Kokolatos <gkokolatos@pm.me>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Teach pg_receivewal to use lz4 compression
Date: Wed, 3 Nov 2021 08:23:46 +0900
Message-ID: <YYHIgrTDI0dEPzoj@paquier.xyz> (raw)
In-Reply-To: <CA+Tgmob3Y=m982YPpZ2HCGMdLMvEGH3FrJvx3dKogPTcS=WV+A@mail.gmail.com>
References: <2sv1K4rAd0hZl65M4_N_yavaqHXnYQJRZOJFK8zMYiHRZsR1BJvXzprxTqi3IzangO5hyuZC5ES-VulHvIU-8B7zJGr15wgF4Dlfbfp2QRk=@pm.me>
	<YUWEqIe4Bx6Q4lcm@paquier.xyz>
	<8CDVNs7db0aITUJjQ8TkK6pX_mO3vTVdpr0niTKodjcNw8DnUIK1fUWHeTYf9oYQP3YfizJT5XevtKdp7xJ04LU_yRI7MY8pPutua3eQAUo=@pm.me>
	<YXvdOb6yo/xxfVce@paquier.xyz>
	<YX+gpFH2s9MG5X3D@paquier.xyz>
	<ckv-SMbj007n51oOS99W6bUCnNvGr4L93Ucse0iTtVj8xSr6_Ws-Zbd6yY4QMUjQHryR4WiemSre8biogFTg1L1kxaYr2FdNZVx-YmTcW5g=@pm.me>
	<YYBp5nmTAy5Xe0pi@paquier.xyz>
	<YYD8Ifj0g4PGlWie@paquier.xyz>
	<CABUevEyWmN-1ksHT6gnsC_e7x4AJSUr+xz=NeOo60ESKNeTntw@mail.gmail.com>
	<CA+Tgmob3Y=m982YPpZ2HCGMdLMvEGH3FrJvx3dKogPTcS=WV+A@mail.gmail.com>

On Tue, Nov 02, 2021 at 12:31:47PM -0400, Robert Haas wrote:
> On Tue, Nov 2, 2021 at 8:17 AM Magnus Hagander <magnus@hagander.net> wrote:
>> I think for the end user, it is strictly better to name it "gzip",
>> and given that the target of this option is the end user we should
>> do so. (It'd be different it we were talking about a build-time
>> parameter to configure). 
> 
> I agree. Also, I think there's actually a file format called "zlib"
> which is slightly different from the "gzip" format, and you have to be
> careful not to generate the wrong one.

Okay, fine by me.  It would be better to be also consistent in
WalCompressionMethods once we switch to this option value, then.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (55+ messages)  latest in thread

Message-ID: <YYHIgrTDI0dEPzoj@paquier.xyz>
Permalink:  ../YYHIgrTDI0dEPzoj@paquier.xyz/
Also on:    postgresql.org/message-id/YYHIgrTDI0dEPzoj@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, robertmhaas@gmail.com, magnus@hagander.net, gkokolatos@pm.me, dilipbalaut@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Teach pg_receivewal to use lz4 compression
  In-Reply-To: <YYHIgrTDI0dEPzoj@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox