From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Date: Tue, 9 Nov 2021 10:51:40 +0900
Message-ID: <YYnULGEY0WNK2lXx@paquier.xyz> (raw)
In-Reply-To: <YYiqxtEqhgb5gIWL@paquier.xyz>
References: <20211107013157.GB790288@rfd.leadboat.com>
<YYiqxtEqhgb5gIWL@paquier.xyz>
On Mon, Nov 08, 2021 at 01:42:46PM +0900, Michael Paquier wrote:
> Indeed. Looking closer, I think that we'd better improve
> DecodingContextFindStartpoint(),
> pg_logical_replication_slot_advance(), XLogSendLogical() as well as
> pg_logical_slot_get_changes_guts() to follow a format closer to what
> you have in your patch, with an error message that describes the
> context where the problem has been found, instead of just elog()'ing
> what XLogReadRecord() returns.
FYI, I have just begun a new thread about those ones:
https://www.postgresql.org/message-id/YYnTH6OyOwQcAdkw@paquier.xyz
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../YYnULGEY0WNK2lXx@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, noah@leadboat.com
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
In-Reply-To: <YYnULGEY0WNK2lXx@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox