From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: Wed, 22 Dec 2021 16:47:12 +0900
Message-ID: <YcLYAPsiDlWF6w7o@paquier.xyz> (raw)
In-Reply-To: <20211221033926.GX17618@telsasoft.com>
References: <711370.1639603043@sss.pgh.pa.us>
<20211215212343.GE4440@momjian.us>
<a89d6602-0fad-c6cc-10cc-20105c4c01ad@dunslane.net>
<20211215221310.GU17618@telsasoft.com>
<YbqYuQkoXm8IytZ0@paquier.xyz>
<c7615cf3-621a-7fc4-79ec-6b2554cd5b68@enterprisedb.com>
<E66B93B0-8579-48BC-9CA4-4C6E3A97408D@yesql.se>
<20211217172113.GL17618@telsasoft.com>
<YcBnT2awK89o6P5I@paquier.xyz>
<20211221033926.GX17618@telsasoft.com>
On Mon, Dec 20, 2021 at 09:39:26PM -0600, Justin Pryzby wrote:
> On Mon, Dec 20, 2021 at 08:21:51PM +0900, Michael Paquier wrote:
>> we could choose something simpler for the default, like
>> "pg_upgrade_log". I don't have a good history in naming new things,
>> though :)
>
> I specifically called it .d to made it obvious that it's a dir - nearly
> everything that ends in "log" is a file, so people are likely to run "rm" and
> "less" on it - including myself.
Okay.
>> .gitignore should be updated, I guess?
>
> Are you suggesting to remove these ?
> -/pg_upgrade_internal.log
> -/loadable_libraries.txt
Yep, it looks so as these are part of the logs, the second one being a
failure state.
> -/reindex_hash.sql
But this one is not, no?
>> Besides, this patch has no documentation.
>
> TBH I'm not even sure if the dir needs to be configurable ?
I'd think it is better to have some control on that. Not sure what
the opinion of others is on this specific point, though.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, pryzby@telsasoft.com, daniel@yesql.se, peter.eisentraut@enterprisedb.com, andrew@dunslane.net, bruce@momjian.us, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
In-Reply-To: <YcLYAPsiDlWF6w7o@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox