From: Michael Paquier <michael@paquier.xyz>
To: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Improve error handling of HMAC computations and SCRAM
Date: Thu, 13 Jan 2022 16:24:31 +0900
Message-ID: <Yd/Tryg7PlGtkpWd@paquier.xyz> (raw)
In-Reply-To: <8cbb56dd-63d6-a581-7a65-25a97ac4be03@postgrespro.ru>
References: <Yd0N9tSAIIkFd+qi@paquier.xyz>
<066c0624-fbb7-a025-afd6-d54683a96947@postgrespro.ru>
<Yd04X0JHdfLgKVC+@paquier.xyz>
<71b9a5d2-a3bf-83bc-a243-93dcf0bcfb3b@postgrespro.ru>
<Yd5RYX89Qy6Okv8u@paquier.xyz>
<Yd68S6Xxmg5d2qRy@paquier.xyz>
<8cbb56dd-63d6-a581-7a65-25a97ac4be03@postgrespro.ru>
On Thu, Jan 13, 2022 at 02:01:24AM +0300, Sergey Shinderuk wrote:
> Gave it a thorough read. Looks good, except for errstr not set in a couple
> of places (see the diff attached).
Thanks for the review. The comments about pg_hmac_ctx->data were
wrong from the beginning, coming, I guess, from one of the earlier
patch versions where this was discussed. So I have applied that
independently.
I have also spent a good amount of time on that to close the loop and
make sure that no code paths are missing an error context, adjusted a
couple of comments to explain more the role of *errstr in all the
SCRAM routines, and finally applied it on HEAD.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../Yd%2FTryg7PlGtkpWd@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, s.shinderuk@postgrespro.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: Improve error handling of HMAC computations and SCRAM
In-Reply-To: <Yd/Tryg7PlGtkpWd@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox