pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Improve error handling of HMAC computations and SCRAM
Date: Thu, 13 Jan 2022 11:26:05 +0300
Message-ID: <f47cfaee-8151-e8e7-2b9c-8f479024b42f@postgrespro.ru> (raw)
In-Reply-To: <Yd/Tryg7PlGtkpWd@paquier.xyz>
References: <Yd0N9tSAIIkFd+qi@paquier.xyz>
	<066c0624-fbb7-a025-afd6-d54683a96947@postgrespro.ru>
	<Yd04X0JHdfLgKVC+@paquier.xyz>
	<71b9a5d2-a3bf-83bc-a243-93dcf0bcfb3b@postgrespro.ru>
	<Yd5RYX89Qy6Okv8u@paquier.xyz>
	<Yd68S6Xxmg5d2qRy@paquier.xyz>
	<8cbb56dd-63d6-a581-7a65-25a97ac4be03@postgrespro.ru>
	<Yd/Tryg7PlGtkpWd@paquier.xyz>

On 13.01.2022 10:24, Michael Paquier wrote:
> Thanks for the review.  The comments about pg_hmac_ctx->data were
> wrong from the beginning, coming, I guess, from one of the earlier
> patch versions where this was discussed.  So I have applied that
> independently.
> 
> I have also spent a good amount of time on that to close the loop and
> make sure that no code paths are missing an error context, adjusted a
> couple of comments to explain more the role of *errstr in all the
> SCRAM routines, and finally applied it on HEAD.
Thanks!

-- 
Sergey Shinderuk		https://postgrespro.com/





view thread (9+ messages)

Message-ID: <f47cfaee-8151-e8e7-2b9c-8f479024b42f@postgrespro.ru>
Permalink:  ../f47cfaee-8151-e8e7-2b9c-8f479024b42f@postgrespro.ru/
Also on:    postgresql.org/message-id/f47cfaee-8151-e8e7-2b9c-8f479024b42f@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: s.shinderuk@postgrespro.ru, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: Improve error handling of HMAC computations and SCRAM
  In-Reply-To: <f47cfaee-8151-e8e7-2b9c-8f479024b42f@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox