From: Bruce Momjian <bruce@momjian.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: Mon, 24 Jan 2022 14:44:21 -0500
Message-ID: <Ye8BlRKfIGfCg802@momjian.us> (raw)
In-Reply-To: <20220124174117.GW23027@telsasoft.com>
References: <Yd00xmV+rdffAQxf@paquier.xyz>
<20220111200307.GA14051@telsasoft.com>
<Yd5SOupY+FHbiXLD@paquier.xyz>
<20220112040813.GD14051@telsasoft.com>
<YefIHrNYTNH/PML4@paquier.xyz>
<45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com>
<Yek+uQp/kMn2O3aK@paquier.xyz>
<Ye4IDNnbMQ5IRxv9@paquier.xyz>
<Ye7kUuo/+we1sipG@momjian.us>
<20220124174117.GW23027@telsasoft.com>
On Mon, Jan 24, 2022 at 11:41:17AM -0600, Justin Pryzby wrote:
> On Mon, Jan 24, 2022 at 12:39:30PM -0500, Bruce Momjian wrote:
> > On Mon, Jan 24, 2022 at 10:59:40AM +0900, Michael Paquier wrote:
> > > On Thu, Jan 20, 2022 at 07:51:37PM +0900, Michael Paquier wrote:
> > > > Neat idea. That would work fine for my case. So I am fine to stick
> > > > with this suggestion.
> > >
> > > I have been looking at this idea, and the result is quite nice, being
> > > simpler than anything that has been proposed on this thread yet. We
> > > get a simpler removal logic, and there is no need to perform any kind
> > > of sanity checks with the output path provided as long as we generate
> > > the paths and the dirs after adjust_data_dir().
> > ...
> > >
> > > <para>
> > > <application>pg_upgrade</application> creates various working files, such
> > > - as schema dumps, in the current working directory. For security, be sure
> > > - that that directory is not readable or writable by any other users.
> > > + as schema dumps, stored within <literal>pg_upgrade_output.d</literal> in
> > > + the directory of the new cluster.
> > > </para>
> >
> > Uh, how are we instructing people to delete that pg_upgrade output
> > directory? If pg_upgrade completes cleanly, would it be removed
> > automatically?
>
> Clearly.
OK, thanks. There are really two cleanups --- first, the "log"
directory, and second deletion of the old cluster by running
delete_old_cluster.sh.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, pryzby@telsasoft.com, michael@paquier.xyz, peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, daniel@yesql.se, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
In-Reply-To: <Ye8BlRKfIGfCg802@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox