pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: Thu, 20 Jan 2022 10:31:15 +0100
Message-ID: <45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com> (raw)
In-Reply-To: <YefIHrNYTNH/PML4@paquier.xyz>
References: <YcBnT2awK89o6P5I@paquier.xyz>
	<20211221033926.GX17618@telsasoft.com>
	<YcLYAPsiDlWF6w7o@paquier.xyz>
	<238201.1640184746@sss.pgh.pa.us>
	<20211222163611.GC17618@telsasoft.com>
	<20220108184857.GI14051@telsasoft.com>
	<Yd00xmV+rdffAQxf@paquier.xyz>
	<20220111200307.GA14051@telsasoft.com>
	<Yd5SOupY+FHbiXLD@paquier.xyz>
	<20220112040813.GD14051@telsasoft.com>
	<YefIHrNYTNH/PML4@paquier.xyz>

On 19.01.22 09:13, Michael Paquier wrote:
> - Renaming of the option from --logdir to --outputdir, as this does
> not include only logs.  That matches also better with default value
> assigned in previous patches, aka pg_upgrade_output.d.

I'm afraid that is too easily confused with the target directory. 
Generally, a tool processes data from input to output or from source to 
target or something like that, whereas a log is more clearly something 
separate from this main processing stream.  The desired "output" of 
pg_upgrade is the upgraded cluster, after all.

A wildcard idea is to put the log output into the target cluster.





view thread (53+ messages)  latest in thread

Message-ID: <45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com>
Permalink:  ../45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com/
Also on:    postgresql.org/message-id/45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz, pryzby@telsasoft.com, tgl@sss.pgh.pa.us, daniel@yesql.se, andrew@dunslane.net, bruce@momjian.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_upgrade should truncate/remove its logs before running
  In-Reply-To: <45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox