pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: tushar <tushar.ahuja@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Dipesh Pandit <dipesh.pandit@gmail.com>
Cc: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: refactoring basebackup.c
Date: Wed, 26 Jan 2022 10:29:29 +0900
Message-ID: <YfCj+QFS6hKlcscJ@paquier.xyz> (raw)
In-Reply-To: <f7b38b10-2ead-1810-b4d2-8fceab32d431@enterprisedb.com>
References: <CAOgcT0N+Nwjx1M_ZP9vr7P_gX9ftMjNrsK6JSYRawdjvTQ7k5A@mail.gmail.com>
	<b9a7a67e-d71a-6d0c-cc59-0ae63e2b2040@enterprisedb.com>
	<CAOgcT0NH+DRkj6pr51DsYyPg73Fuj-uLpr707akfZcbaxTqdvQ@mail.gmail.com>
	<CAC6VRoYRJkzRxU_TVG7PMGMn5+Eb-VSOiO+mVaj2WUyeF9DpkA@mail.gmail.com>
	<CAOgcT0NBurXSm+ZeF=PiBcAm9mywHFo6Jc9G+F7JFU8O9sndBQ@mail.gmail.com>
	<CA+TgmoZ5_j+ZLf66_EioReGXvYTCkgQZju9SDq8yg_QbY_1vTw@mail.gmail.com>
	<CAN1g5_FSqShfWKibkCrJr45hHtRCBQUUtGVEHn4wNv=YCkybtQ@mail.gmail.com>
	<CA+TgmobQYkP81QQgS6tvvt4cRxvmipHQ4eU-aNjSpiZJhdkckA@mail.gmail.com>
	<CA+Tgmoa-ST7fMLsVJduOB7Eub=2WjfpHS+QxHVEpUoinf4bOSg@mail.gmail.com>
	<f7b38b10-2ead-1810-b4d2-8fceab32d431@enterprisedb.com>

On Tue, Jan 25, 2022 at 09:52:12PM +0530, tushar wrote:
> C) -R option is silently ignoring
> 
> go to /tmp/pp folder and extract it - there is no "standby.signal" file and
> if we start cluster against this data directory,it will not be in slave
> mode.

Yeah, I don't think it's good to silently ignore the option, and we
should not generate the file on the server-side.  Rather than erroring
in this case, you'd better add the file to the existing compressed
file of the base data folder on the client-side.

This makes me wonder whether we should begin tracking any open items
for v15..  We don't want to lose track of any issue with features
committed already in the tree.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (171+ messages)  latest in thread

Message-ID: <YfCj+QFS6hKlcscJ@paquier.xyz>
Permalink:  ../YfCj+QFS6hKlcscJ@paquier.xyz/
Also on:    postgresql.org/message-id/YfCj+QFS6hKlcscJ@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, tushar.ahuja@enterprisedb.com, robertmhaas@gmail.com, dipesh.pandit@gmail.com, jeevan.ladhe@enterprisedb.com, 9erthalion6@gmail.com, mark.dilger@enterprisedb.com
  Subject: Re: refactoring basebackup.c
  In-Reply-To: <YfCj+QFS6hKlcscJ@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox