From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade test writes to source directory
Date: Thu, 2 Jun 2022 09:37:58 +0900
Message-ID: <YpgGZpoBr59O2yvu@paquier.xyz> (raw)
In-Reply-To: <20220601211112.td2ato4wjqf7afnv@alap3.anarazel.de>
References: <Yo/5MlXbwY4UhMnm@paquier.xyz>
<2464542.1653603596@sss.pgh.pa.us>
<YpAMBqPrusng47e0@paquier.xyz>
<2480063.1653609068@sss.pgh.pa.us>
<YpAV1y8CUXGGkPJQ@paquier.xyz>
<20220528195949.tte5fukfr2z6xhrr@alap3.anarazel.de>
<3131727.1653768841@sss.pgh.pa.us>
<YpXA7XHZtunxalTr@paquier.xyz>
<e65a862a-24aa-7482-6d98-49fbb048f22f@enterprisedb.com>
<20220601211112.td2ato4wjqf7afnv@alap3.anarazel.de>
On Wed, Jun 01, 2022 at 02:11:12PM -0700, Andres Freund wrote:
> Until recently TESTDIR needed to point to the build directory containing the
> binaries. But I'd like to be able to separate test log output from the build
> tree, so that it's easier to capture files generated by tests for CI /
> buildfarm. The goal is to have a separate directory for each test, so we can
> present logs for failed tests separately. That was impossible with TESTDIR,
> because it needed to point to the build directory.
FWIW, this argument sounds sensible to me since I looked at 0001, not
only for the log files, but also to help in the capture of files
generated by the tests like 010_tab_completion.pl.
I don't know yet what to do about this part, so for now I have fixed
the other issue reported by Peter where the test names were missing.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../YpgGZpoBr59O2yvu@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, pryzby@telsasoft.com
Subject: Re: pg_upgrade test writes to source directory
In-Reply-To: <YpgGZpoBr59O2yvu@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox