public inbox for [email protected]  

help / color / mirror / Atom feed

From: Justin Pryzby <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Juan José Santamaría Flecha <[email protected]>
Cc: [email protected]
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Date: Thu, 8 Sep 2022 08:29:20 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CA+hUKGL1p7BHdZc_GEBYkLarPzFEAYKd_HXA_NJ_ct4dJCD-iw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<YsZnhwERsDv/[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+hUKG+BMdcaCe=P-EjMoLTCr3zrrzqbcVE=8h5LyNsSVHKXZA@mail.gmail.com>
	<[email protected]>

On Thu, Sep 08, 2022 at 05:55:40PM +0900, Michael Paquier wrote:
> On Tue, Aug 30, 2022 at 01:29:24PM +1200, Thomas Munro wrote:
> > This reminds me of 24c3ce8f1, which replaced a dlopen()-ish thing with
> > a direct function call.  Can you just call all these functions
> > directly these days?
> 
> Hmm.  Some tests in the CI show that attempting to call directly
> MiniDumpWriteDump() causes a linking failure at compilation.  Anyway,
> in the same fashion, I can get some simplifications done right for
> pg_ctl.c, auth.c and restricted_token.c.  And I am seeing all these
> functions listed in the headers of MinGW, meaning that all these
> should work out of the box in this case, no?
> 
> The others are library-dependent, and I not really confident about
> ldap_start_tls_sA().  So, at the end, I am finishing with the
> attached, what do you think?  This cuts some code, which is nice:
>  3 files changed, 48 insertions(+), 159 deletions(-)

+1

It seems silly to do it at runtime if it's possible to do it at link time.

-- 
Justin

view thread (32+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox