From: Michael Paquier <michael@paquier.xyz>
To: Florin Irion <irionr@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_create_logical_replication_slot argument incongruency
Date: Tue, 20 Sep 2022 10:33:24 +0900
Message-ID: <YykYZI8RChKycDe9@paquier.xyz> (raw)
In-Reply-To: <CA+HEvJDmFSKmqaXYuPNjkGpTboE35s_PifOg2AqwVJBn5rWGzw@mail.gmail.com>
References: <CA+HEvJDmFSKmqaXYuPNjkGpTboE35s_PifOg2AqwVJBn5rWGzw@mail.gmail.com>
On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote:
> This was introduced in commit 19890a06.
>
> IMHO we should use the documented argument name `two_phase` and change the
> function to accept it.
>
> What do you think?
19890a0 is included in REL_14_STABLE, and changing an argument name is
not acceptable in a stable branch as it would imply a catversion
bump. Let's change the docs so as we document the parameter as
"twophase", instead.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, irionr@gmail.com
Subject: Re: pg_create_logical_replication_slot argument incongruency
In-Reply-To: <YykYZI8RChKycDe9@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox