From: Nathan Bossart <nathandbossart@gmail.com>
To: Dimitrios Apostolou <jimis@gmx.net>
Cc: pgsql-hackers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [PATCH v1] parallel pg_restore: avoid disk seeks when jumping short distance forward
Date: Tue, 1 Apr 2025 15:04:00 -0500
Message-ID: <Z-xGsMvMgLYyPfjc@nathan> (raw)
In-Reply-To: <465a7ab4-2a61-ebf9-5779-1733d1c12903@gmx.net>
References: <2edb7a57-b225-3b23-a680-62ba90658fec@gmx.net>
<465a7ab4-2a61-ebf9-5779-1733d1c12903@gmx.net>
On Tue, Apr 01, 2025 at 09:33:32PM +0200, Dimitrios Apostolou wrote:
> It didn't break any test, but I also don't see any difference, the
> performance boost is noticeable only when restoring a huge archive that is
> missing offsets.
This seems generally reasonable to me, but how did you decide on 1MB as the
threshold? Have you tested other values? Could the best threshold vary
based on the workload and hardware?
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, jimis@gmx.net, tgl@sss.pgh.pa.us
Subject: Re: [PATCH v1] parallel pg_restore: avoid disk seeks when jumping short distance forward
In-Reply-To: <Z-xGsMvMgLYyPfjc@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox