From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Cc: dipiets@amazon.com
Subject: Re: use a non-locking initial test in TAS_SPIN on AArch64
Date: Fri, 10 Jan 2025 13:19:55 -0600
Message-ID: <Z4Fy23e7iCmZi1Dk@nathan> (raw)
In-Reply-To: <Z4FQHBrAiFXhE4ZM@nathan>
References: <ZxgDEb_VpWyNZKB_@nathan>
<Z37AA6-SsJoLaifa@nathan>
<tdex7aj3zrvdu22dfgtljbrybrjezbjpr374otnadi6qxywkmc@rzxtb2fbubpy>
<Z371r_AVOU0WCrBr@nathan>
<tb6d2bg5a3so2325opkaow3ptkvpgpxzz3nnkehb3x7d77g3sx@xjid7uptuoni>
<Z37-Svaqt7XCBcXP@nathan>
<Z4FQHBrAiFXhE4ZM@nathan>
On Fri, Jan 10, 2025 at 10:51:40AM -0600, Nathan Bossart wrote:
> Actually, I think I may have just had back luck and/or not warmed things up
> enough. I just re-ran the test a few dozen times, carefully ensuring the
> data was in the cache and periodically alternating between the binary with
> the patch applied and the one without it. The results converged to within
> 1-2% of each other, with the patched version even winning about half the
> time. The averages across all the runs showed a ~0.4% regression, which I
> suspect is well within the noise range.
I went ahead and committed this patch. Please let me know if there are any
remaining concerns.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, andres@anarazel.de, dipiets@amazon.com
Subject: Re: use a non-locking initial test in TAS_SPIN on AArch64
In-Reply-To: <Z4Fy23e7iCmZi1Dk@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox