From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Andy Fan <zhihuifan1213@163.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgbench error: (setshell) of script 0; execution of meta-command failed
Date: Tue, 14 Jan 2025 14:49:27 -0600
Message-ID: <Z4bN1z_Ce_lxldj4@nathan> (raw)
In-Reply-To: <717458.1736884349@sss.pgh.pa.us>
References: <87ikqn5em7.fsf@163.com>
<e03fc711-8c48-4fb8-ba94-0862c920c30f@oss.nttdata.com>
<b0afe844-84b7-4154-ad2c-6763ff84d876@oss.nttdata.com>
<2422778.1736521065@sss.pgh.pa.us>
<2425050.1736522451@sss.pgh.pa.us>
<127979.1736622253@sss.pgh.pa.us>
<Z4U5j_FWpNLjtdU8@nathan>
<570943.1736808714@sss.pgh.pa.us>
<Z4aRAdGdw8GiU7ba@nathan>
<717458.1736884349@sss.pgh.pa.us>
On Tue, Jan 14, 2025 at 02:52:29PM -0500, Tom Lane wrote:
> After more thought I've realized that the asymmetrical detection
> here isn't all that bad, because the outcomes are different.
> If we fail to catch old-headers-and-new-library, the result will
> either be a link failure or (if the extension uses libpq) silently
> linking to libpq's pqsignal, which was likely not what was intended.
> If we fail to catch the other case, the result is always a link
> failure, and that will happen at build time not in the field.
Assuming libpgport is only used as a static library, I think that makes
sense. My web searches indicate that it is possible to do things like
convert a static library to a dynamic one, but perhaps that's far enough
beyond the realm of things we care about.
> So now I'm inclined to include the ABI-compatible wrapper, which
> will ensure that extensions continue to link to libpgport's pqsignal.
Fine by me.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, masao.fujii@oss.nttdata.com, zhihuifan1213@163.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgbench error: (setshell) of script 0; execution of meta-command failed
In-Reply-To: <Z4bN1z_Ce_lxldj4@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox