From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: pgsql-release@lists.postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix for Extra Parenthesis in pgbench progress message
Date: Fri, 7 Feb 2025 11:57:12 -0600
Message-ID: <Z6ZJeMold-CjtmR4@nathan> (raw)
In-Reply-To: <4k4drkh7bcmdezq6zbkhp25mnrzpswqi2o75d5uv2eeg3aq6q7@b7kqdmzzwzgb>
References: <85fe426d-248a-47f7-8784-22af811ee572@oss.nttdata.com>
<20241108.114713.484828673471024549.ishii@postgresql.org>
<95f1100e-e59b-41b7-a406-f865c2e69db7@oss.nttdata.com>
<20241125.083155.1820744655877715597.ishii@postgresql.org>
<ffc99be5-e418-40ee-91d6-62c3deb42918@oss.nttdata.com>
<4k4drkh7bcmdezq6zbkhp25mnrzpswqi2o75d5uv2eeg3aq6q7@b7kqdmzzwzgb>
On Fri, Feb 07, 2025 at 12:28:16PM -0500, Andres Freund wrote:
> I just did pgbench -i 100 -q via ssh and noticed it was *way* slower than I
> expected. Did it with debian's pgbench, no such issue.
>
> It's due to this patch.
>
> /srv/dev/build/m-opt/src/bin/pgbench/pgbench -i -s 10 -Idtg -h /tmp -q > /tmp/pgiu 2>&1
>
> With HEAD:
> pgbench -i -s 10 -Idtg -h /tmp -q 2>&1|wc
> 1000114 52 1000448
>
> With af35fe501af reverted:
> pgbench -i -s 10 -Idtg -h /tmp -q 2>&1|wc
> 6 52 340
>
> Outputting that many lines to the terminal causes noticeable slowdowns even
> locally and make the terminal use a *lot* more cpu cycles.
Presumably we should only fputc(eol, stderr) when we actually fprintf()
above this point.
> Given the upcoming set of minor releases, I think it may be best for this this
> patch ought to be reverted for now.
+1, since we're nearing the freeze and this doesn't seem like a
particularly urgent bug fix.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, andres@anarazel.de, masao.fujii@oss.nttdata.com, ishii@postgresql.org, pgsql-release@lists.postgresql.org
Subject: Re: Fix for Extra Parenthesis in pgbench progress message
In-Reply-To: <Z6ZJeMold-CjtmR4@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox