From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: add PROCESS_MAIN to VACUUM
Date: Mon, 6 Mar 2023 16:51:46 +0900
Message-ID: <ZAWbkiZSdFZOTS7F@paquier.xyz> (raw)
In-Reply-To: <20230302065359.GA2140777@nathanxps13>
References: <20221230000028.GA435655@nathanxps13>
<20230107050724.GA914213@nathanxps13>
<CALDaNm1bKSNG9Jc1mrtk2ZWsVdvTQw+XOnbB3yL_Xf57oAdg5Q@mail.gmail.com>
<20230119190807.GA4062411@nathanxps13>
<Y/7xVESfLgw3E/F/@paquier.xyz>
<20230301172637.GA1456203@nathanxps13>
<ZAA5vt7jUTRpPDmL@paquier.xyz>
<20230302065359.GA2140777@nathanxps13>
On Wed, Mar 01, 2023 at 10:53:59PM -0800, Nathan Bossart wrote:
> I don't feel a strong need for that, especially now that we aren't
> modifying params anymore.
That was mostly OK for me, so applied after tweaking a couple of
places in the tests (extra explanations, for one), the comments and
the code.
The part that improved the tests of PROCESS_TOAST was useful on its
own, so I have done that separately as 46d490a. Another thing that I
have found incorrect is the need for two pg_stat_reset() calls that
would reflect on the whole database, in the middle of a test running
in parallel of other things. As far as I understand, you have added
that to provide fresh data after a single command while relying on
vactst, but it is possible to get the same amount of coverage by
relying on cumulated counts, and that gets even more solid with all
these commands run on an independent table.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ZAWbkiZSdFZOTS7F@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, nathandbossart@gmail.com, vignesh21@gmail.com
Subject: Re: add PROCESS_MAIN to VACUUM
In-Reply-To: <ZAWbkiZSdFZOTS7F@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox