From: Michael Paquier <michael@paquier.xyz>
To: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields
Date: Wed, 22 Mar 2023 10:28:19 +0900
Message-ID: <ZBpZsxwl1pMS2pQL@paquier.xyz> (raw)
In-Reply-To: <a6eb68a6-1cfb-9290-ab31-e3bba292d3ac@gmail.com>
References: <9142f62a-a422-145c-bde0-b5bc498a4ada@gmail.com>
<20230112171252.xucefmthy5l4l2ec@alvherre.pgsql>
<20230112180733.agmvpugp6ggorade@awork3.anarazel.de>
<ZBgL/gO/es0D0EeR@paquier.xyz>
<a6eb68a6-1cfb-9290-ab31-e3bba292d3ac@gmail.com>
On Mon, Mar 20, 2023 at 10:05:21AM +0100, Drouvot, Bertrand wrote:
> Good point and keeping it as it is currently would not
> affect the work that is/will be done in [1].
I guess that I'm OK with that to get more of pgstatfuncs.c to use
macros for the function definitions there.. Alvaro, Tom, perhaps you
still think that this is unadapted? Based on the file split and the
references to funcentry and tabentry, I think that's OK, but that
stands just as one opinion among many..
> So, please find attached V2 attached taking this comment into account.
> [1]: https://www.postgresql.org/message-id/flat/89606d96-cd94-af74-18f3-c7ab2b684ba2%40gmail.com
Nice. I am pretty sure that finishing some of that is doable by the
end of this CF to reduce the size of pgstatfuncs.c overall.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, bertranddrouvot.pg@gmail.com, andres@anarazel.de, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields
In-Reply-To: <ZBpZsxwl1pMS2pQL@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox