From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: pgsql-hackers@postgresql.org, gkokolatos@pm.me, Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Dipesh Pandit <dipesh.pandit@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Subject: Re: zstd compression for pg_dump
Date: Thu, 6 Apr 2023 11:10:17 -0500
Message-ID: <ZC7u6at4J3XXrH2z@telsasoft.com> (raw)
In-Reply-To: <d62901d9-e945-049f-5b0e-7f645d83a1b9@enterprisedb.com>
References: <4029fe58-f661-7d8d-cbbb-b936a05531e2@enterprisedb.com>
<ZCd6sb7XA/W6nLaD@telsasoft.com>
<2de3bcad-6da9-9022-bce5-fc0416351d6e@enterprisedb.com>
<ZCgzbBVKLvwpqMzT@telsasoft.com>
<f3947107-a95a-348c-263c-284ac7275ae0@enterprisedb.com>
<ZCsmSoiBMVfrlOXm@telsasoft.com>
<27eb89fc-8fdd-2988-0959-0af1d6d7a12a@enterprisedb.com>
<ZCuTotQ38nwA/hLY@telsasoft.com>
<51013008-6735-96a2-d744-3b0a0413fcdd@enterprisedb.com>
<d62901d9-e945-049f-5b0e-7f645d83a1b9@enterprisedb.com>
On Thu, Apr 06, 2023 at 05:34:30PM +0200, Tomas Vondra wrote:
> I looked at the long mode patch again, updated the commit message and
> pushed it. I was wondering if long_mode should really be bool -
> logically it is, but ZSTD_CCtx_setParameter() expects int. But I think
> that's fine.
Thanks!
> I think that's all for PG16 in this patch series. If there's more we want to
> do, it'll have to wait for PG17 -
Yes
> Justin, can you update and submit the patches that you think are relevant for
> the next CF?
Yeah.
It sounds like a shiny new feature, but it's not totally clear if it's safe
here or even how useful it is. (It might be like my patch for
wal_compression=zstd:level, and Michael's for toast_compression=zstd, neither
of which saw any support).
Last year's basebackup thread had some interesting comments about safety of
threads, although pg_dump's considerations may be different.
The patch itself is trivial, so it'd be fine to wait until PG16 is released to
get some experience. If someone else wanted to do that, it'd be fine with me.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, tomas.vondra@enterprisedb.com, jchampion@timescale.com, michael@paquier.xyz, robertmhaas@gmail.com, pg@bowt.ie, peter.eisentraut@enterprisedb.com, hlinnaka@iki.fi, thomas.munro@gmail.com, dipesh.pandit@gmail.com, x4mmm@yandex-team.ru, mark.dilger@enterprisedb.com
Subject: Re: zstd compression for pg_dump
In-Reply-To: <ZC7u6at4J3XXrH2z@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox