From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: longfin missing gssapi_ext.h
Date: Fri, 7 Apr 2023 22:38:33 -0400
Message-ID: <ZDDTqZjoWdR/woAC@tamriel.snowman.net> (raw)
In-Reply-To: <ZDDSriHdl6+LwVl6@tamriel.snowman.net>
References: <ZDDO6jaESKaBgej0@tamriel.snowman.net>
<3282942.1680920692@sss.pgh.pa.us>
<ZDDRNbHzkdQNBdpZ@tamriel.snowman.net>
<3284314.1680921096@sss.pgh.pa.us>
<ZDDSriHdl6+LwVl6@tamriel.snowman.net>
Greetings,
* Stephen Frost (sfrost@snowman.net) wrote:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> > Stephen Frost <sfrost@snowman.net> writes:
> > > * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> > >> It's whatever Apple is shipping, or was shipping last year or so.
> >
> > > Sadly they've not been maintaining the Kerberos libraries at all on
> > > their systems.
> >
> > Indeed :-(. I wouldn't be surprised if there are security issues in
> > their version. Perhaps what we really ought to do is refuse to build
> > with their version --- but if so, we need some clearer error message
> > about it.
>
> The attached should (I believe?) at least add the needed check for
> gssapi_ext.h which will cause builds to fail and complain about the
> header being missing from their installation.
>
> I'm certainly open to ideas about how to provide a better error message,
> particularly on OSX systems which have an ancient version, to make it
> clear that people need to install an updated version. I don't have an
> OSX system at hand though.
>
> Should I push this to at least address the header check ... ?
Looks like buildfarm animal hake, at least, has a version recent enough
to have gssapi_ext.h ... but still older than 1.11 and therefore
doesn't have the type gss_key_value_element_desc defined, so maybe the
check for gss_store_cred_into would be better?
Certainly interesting how many old kerberos library installations there
are, even in our buildfarm..
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us
Subject: Re: longfin missing gssapi_ext.h
In-Reply-To: <ZDDTqZjoWdR/woAC@tamriel.snowman.net>
References: <ZDDO6jaESKaBgej0@tamriel.snowman.net> <3282942.1680920692@sss.pgh.pa.us> <ZDDRNbHzkdQNBdpZ@tamriel.snowman.net> <3284314.1680921096@sss.pgh.pa.us> <ZDDSriHdl6+LwVl6@tamriel.snowman.net> <ZDDTqZjoWdR/woAC@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox