From: Justin Pryzby <pryzby@telsasoft.com>
To: Thom Brown <thom@linux.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Various typo fixes
Date: Tue, 11 Apr 2023 09:53:00 -0500
Message-ID: <ZDV0TG+YlnBpmpRD@telsasoft.com> (raw)
In-Reply-To: <CAA-aLv6D9mAui-Lh1yZaL_kACiKhuK6j0PKm_Setndb9JW+TRQ@mail.gmail.com>
References: <CAA-aLv7xCZ0nBJa-NWe0rxBB28TjFjS2JtjiZMoQ+0wsugG+hQ@mail.gmail.com>
<ZDVxDZPMjN0LKPtd@telsasoft.com>
<CAA-aLv6D9mAui-Lh1yZaL_kACiKhuK6j0PKm_Setndb9JW+TRQ@mail.gmail.com>
On Tue, Apr 11, 2023 at 03:43:12PM +0100, Thom Brown wrote:
> On Tue, 11 Apr 2023 at 15:39, Justin Pryzby <pryzby@telsasoft.com> wrote:
> >
> > On Tue, Apr 11, 2023 at 03:36:02PM +0100, Thom Brown wrote:
> > > I've attached a patch with a few typo and grammatical fixes.
> >
> > I think you actually sent the "git-diff" manpage :(
>
> Oh dear, well that's a first. Thanks for pointing out.
Thanks. I think these are all new in v16, right ?
I noticed some of these too - I'll send a patch pretty soon.
|+++ b/doc/src/sgml/logicaldecoding.sgml
|@@ -326,11 +326,11 @@ postgres=# select * from pg_logical_slot_get_changes('regression_slot', NULL, NU
| connection is alive (for example a node restart would break it). Then, the
| primary may delete system catalog rows that could be needed by the logical
| decoding on the standby (as it does not know about the catalog_xmin on the
|- standby). Existing logical slots on standby also get invalidated if wal_level
|- on primary is reduced to less than 'logical'. This is done as soon as the
|- standby detects such a change in the WAL stream. It means, that for walsenders
|- that are lagging (if any), some WAL records up to the wal_level parameter change
|- on the primary won't be decoded.
|+ standby). Existing logical slots on standby also get invalidated if
|+ <varname>wal_level</varname> on the primary is reduced to less than 'logical'.
|+ This is done as soon as the standby detects such a change in the WAL stream.
|+ It means that, for walsenders which are lagging (if any), some WAL records up
|+ to the wal_level parameter change on the primary won't be decoded.
| </para>
I think "logical" should be a <literal> here.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, thom@linux.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Various typo fixes
In-Reply-To: <ZDV0TG+YlnBpmpRD@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox