From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: gkokolatos@pm.me, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Date: Wed, 12 Apr 2023 17:52:40 -0500
Message-ID: <ZDc2OBeMYbhmDEYl@telsasoft.com> (raw)
In-Reply-To: <ZDcvdPVVi22mXPfR@paquier.xyz>
References: <qRJGr1JjK3B_pbOxyGqI0iGJWEcRxnq9c7_mIqTY1CIIvYMY0hamPIrvjuS-6gyjr_ItOG8SLRacF1oj7d8R4QKHfZp85YTHI9B-U6LSLAQ=@pm.me>
<qSzzmYsXqUf1gDvFspOEbqoE8U_F8IsphDG8c25VZ5KTXimQVYfLvnCcuU7_X2raa2SzZinDF0NpDIKSOALRUYP8pu_NL5QJwIDdR_RT-4U=@pm.me>
<8ffd14fe-0278-7f8d-78d4-472816d06268@enterprisedb.com>
<ZDX+J72FYmJhH+fC@telsasoft.com>
<ZDYEPDbFAua+4hlr@paquier.xyz>
<ZDYHP4SvY2eejTj/@telsasoft.com>
<ZDcvdPVVi22mXPfR@paquier.xyz>
On Thu, Apr 13, 2023 at 07:23:48AM +0900, Michael Paquier wrote:
> On Tue, Apr 11, 2023 at 08:19:59PM -0500, Justin Pryzby wrote:
> > On Wed, Apr 12, 2023 at 10:07:08AM +0900, Michael Paquier wrote:
> >> Yes, this comment gives no value as it stands. I would be tempted to
> >> follow the suggestion to group the whole code block in a single ifdef,
> >> including the check, and remove this comment. Like the attached
> >> perhaps?
> >
> > +1
>
> Let me try this one again, as the previous patch would cause a warning
> under --without:-zlib as user_compression_defined would be unused. We
> could do something like the attached instead. It means doing twice
> parse_compress_specification() for the non-zlib path, still we are
> already doing so for the zlib path.
>
> If there are other ideas, feel free.
I don't think you need to call parse_compress_specification(NONE).
As you wrote it, if zlib is unavailable, there's no parse(NONE) call,
even for directory and custom formats. And there's no parse(NONE) call
for plan format when zlib is available.
The old way had preprocessor #if around both the "if" and "else" - is
that what you meant ?
If you don't insist on calling parse(NONE), the only change is to remove
the empty #else, which was my original patch.
"if no compression specification has been specified" is redundant with
"by default", and causes "not the others" to dangle.
If I were to rewrite the comment, it'd say:
+ * When gzip is available, custom and directory formats are compressed by
+ * default
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, tomas.vondra@enterprisedb.com, rachelmheaton@gmail.com
Subject: Re: Add LZ4 compression in pg_dump
In-Reply-To: <ZDc2OBeMYbhmDEYl@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox