From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix typos and inconsistencies for v16
Date: Tue, 2 May 2023 12:26:31 +0900
Message-ID: <ZFCC58SPNcK/426H@paquier.xyz> (raw)
In-Reply-To: <e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com>
References: <d5f68d19-c0fc-91a9-118d-7c6a5a3f5fad@gmail.com>
<ZD3D1QxoccnN8A1V@telsasoft.com>
<699beab4-a6ca-92c9-f152-f559caf6dc25@gmail.com>
<CAApHDvqUdoxzLaVU16Ktx83qiroYrmxNTpwvd5GAcLH+ZH51Pg@mail.gmail.com>
<e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com>
On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote:
> Please look at the following two bunches for v14+ and v13+ (split to ease
> back-patching if needed). Having processed them, I've reached the state that
> could be considered "clean" ([2], [3]); at least I don't see how to detect
> yet more errors of this class in dozens, so it's my last run for now (though I
> have several entities left, which I couldn't find replacements for).
This was hanging around, and I had some time, so I have looked at the
whole. One of the only two user-visible change was in the docs for
pg_amcheck, so I have applied that first as of 6fd8ae6 and backpatched
it down to 14.
Now, for the remaining 59..
> 1. agg_init_trans_check -> agg_trans
> 2. agg_strict_trans_check -> agg_trans
/*
* pergroup = &aggstate->all_pergroups
- * [op->d.agg_strict_trans_check.setoff]
- * [op->d.agg_init_trans_check.transno];
+ * [op->d.agg_trans.setoff]
+ * [op->d.agg_trans.transno];
*/
Honestly, while incorrect, I have no idea what this comment means ;)
> 4. CommitTSBuffer -> CommitTsBuffer // the inconsistency exists since 5da14938f; maybe this change should be backpatched
Yes, we'd better backpatch that. I agree that it seems more sensible
here to switch the compiled value rather than what the docs have been
using for years. Perhaps somebody has a different opinion?
The others were OK and in line with the discussion of upthread, so
applied.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ZFCC58SPNcK%2F426H@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, exclusion@gmail.com, dgrowleyml@gmail.com, pryzby@telsasoft.com
Subject: Re: Fix typos and inconsistencies for v16
In-Reply-To: <ZFCC58SPNcK/426H@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox