public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Amit Kapila <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Implement generalized sub routine find_in_log for tap test
Date: Tue, 6 Jun 2023 13:06:33 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1Kbyo-L3nfMnZbusgv_a7jejxcm1gsDBJ2VH5KnK1rkTw@mail.gmail.com>
References: <CALDaNm0YSiLpjCmajwLfidQrFOrLNKPQir7s__PeVvh9U3uoTQ@mail.gmail.com>
<[email protected]>
<ZG/[email protected]>
<CALDaNm1sDD-MCW6zrxHCC7Ka5AzO-L4ejxeeTMtXPPN+F4vz2Q@mail.gmail.com>
<[email protected]>
<CALDaNm3SWpFDTs1oRRbOAfYJNuSPMCLu4O3mLnU-tKoSFgGckQ@mail.gmail.com>
<[email protected]>
<CAA4eK1Kbyo-L3nfMnZbusgv_a7jejxcm1gsDBJ2VH5KnK1rkTw@mail.gmail.com>
On Tue, Jun 06, 2023 at 08:05:49AM +0530, Amit Kapila wrote:
> Personally, I don't see any problem to do this refactoring for v16.
> However, sometimes, we do decide to backpatch refactoring in tests to
> avoid backpatch effort. I am not completely sure if that is the case
> here.
033_replay_tsp_drops.pl has one find_in_log() down to 11, and
019_replslot_limit.pl has four calls down to 14. Making things
consistent everywhere is a rather appealing argument to ease future
backpatching. So I am OK to spend a few extra cycles in adjusting
these routines all the way down where needed. I'll do that tomorrow
once I get back in front of my laptop.
Note that connect_ok() and connect_fails() are new to 14, so this
part has no need to go further down than that.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Implement generalized sub routine find_in_log for tap test
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox