From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: ikedamsh@oss.nttdata.com
Cc: bharath.rupireddyforpostgres@gmail.com
Cc: tristan@neon.tech
Cc: andres@anarazel.de
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Support to define custom wait events for extensions
Date: Mon, 31 Jul 2023 19:24:09 +0900
Message-ID: <ZMeLyUC48EnY0mNP@paquier.xyz> (raw)
In-Reply-To: <20230731.171021.2208978510550133838.horikyota.ntt@gmail.com>
References: <ZMcJ7F7nkGkIs8zP@paquier.xyz>
<446d286f3272437df705ee69ad0d8793@oss.nttdata.com>
<ZMdikEm4Xq9KQKNY@paquier.xyz>
<20230731.171021.2208978510550133838.horikyota.ntt@gmail.com>
On Mon, Jul 31, 2023 at 05:10:21PM +0900, Kyotaro Horiguchi wrote:
> +/*
> + * Return the name of an wait event ID for extension.
> + */
> +static const char *
> +GetWaitEventExtensionIdentifier(uint16 eventId)
>
> This looks inconsistent. Shouldn't it be GetWaitEventExtentionName()?
This is an inspiration from GetLWLockIdentifier(), which is kind of OK
by me. If there is a consensus in changing that, fine by me, of
course.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, horikyota.ntt@gmail.com, ikedamsh@oss.nttdata.com, bharath.rupireddyforpostgres@gmail.com, tristan@neon.tech, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Support to define custom wait events for extensions
In-Reply-To: <ZMeLyUC48EnY0mNP@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox