From: Michael Paquier <michael@paquier.xyz>
To: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z
Date: Thu, 21 Sep 2023 11:32:57 +0900
Message-ID: <ZQurWbkV9KJ96LSf@paquier.xyz> (raw)
In-Reply-To: <08930c0b541700a5264e5fbf3a685f5a@oss.nttdata.com>
References: <08930c0b541700a5264e5fbf3a685f5a@oss.nttdata.com>
On Thu, Sep 21, 2023 at 10:44:49AM +0900, Ryoga Yoshida wrote:
> When --buffer-usage-limit option is specified, vacuumdb issues VACUUM or
> VACUUM ANALYZE command with BUFFER_USAGE_LIMIT option. Also if
> --buffer-usage-limit and -Z options are specified, vacuumdb should issue
> ANALYZE command with BUFFER_USAGE_LIMIT option. But it does not. That is,
> vacuumdb -Z seems to fail to handle --buffer-usage-limit option. This seems
> a bug.
>
> You can see my patch in the attached file and how it works by adding -e
> option in vacuumdb.
Good catch, indeed the option is missing from the ANALYZE commands
built under analyze_only. I can also notice that we have no tests for
this option in src/bin/scripts/t checking the shape of the commands
generated. Could you add something for ANALYZE and VACUUM? The
option could just be appended in one of the existing cases, for
instance.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, bt23yoshidar@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z
In-Reply-To: <ZQurWbkV9KJ96LSf@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox