pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag
Date: Fri, 6 Oct 2023 15:29:28 +0900
Message-ID: <ZR-pSNRTY2izuNdg@paquier.xyz> (raw)
In-Reply-To: <ZR9QJrNJ8lJDZ41P@paquier.xyz>
References: <ZRZsg2pqrCQ9dlsn@paquier.xyz>
	<eea89922-70e2-4a50-b990-4c6a9757a840@gmail.com>
	<ZRp8t67SqcF2oYqM@paquier.xyz>
	<566c1686-c80b-4d4a-b496-b00ac428a095@gmail.com>
	<ZR0EEUyWA1Nuz6CK@paquier.xyz>
	<83f72bb9-f3cf-4344-8d4d-45e128813d58@gmail.com>
	<ZR5FRByOl2y8dORo@paquier.xyz>
	<26e7cd6a-6dd1-4b08-975b-62603eeb6f3f@gmail.com>
	<CALj2ACUJf8ftjiTiNfuVKTvUM3N++dWKnhBOg1EJ29CwoTkXew@mail.gmail.com>
	<ZR9QJrNJ8lJDZ41P@paquier.xyz>

On Fri, Oct 06, 2023 at 09:09:10AM +0900, Michael Paquier wrote:
> I am not completely sure what you mean here.  We've never supported
> load_session_libraries for background workers, and I'm not quite sure
> that there is a case for it.  FWIW, my idea around that would be to
> have two separate sets of flags: one set for the bgworkers and one set
> for PostgresInit() as an effect of load_session_libraries which looks
> like a fuzzy concept for bgworkers.

I have applied v1 a few hours ago as of 991bb0f9653c.  Then, the
buildfarm has quickly complained that a bgworkers able to start with 
BYPASS_ALLOWCONN while the database has its access restricted could
spawn workers that themselves try to connect to the database
restricted, causing the test to fail.  I have applied fd4d93d269c0 as
a quick way to avoid the spawn of workers in this case, and the
buildfarm has turned back to green.

Now, there's been a second type failure on serinus even after all
that:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=serinus&dt=2023-10-06%2001%3A04%3A05

The step running a `make check` on worker_spi in the run has worked:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=serinus&dt=2023-10-06%2001%3A04%3A...

But the follow-up step doing an installcheck with worker_spi has not.
And this looks like a crash:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=serinus&dt=2023-10-06%2001%3A04%3A...

The logs reported by this step are not really helpful, as they contain
only information about the sql/ tests in the modules.  It is the first
time that this stuff is tested, so this could be a race condition
that's been around for some time but we've never seen it until now, or
it could be an issue in the test I fail to see.

Andres, are there logs for this TAP test on serinus?  Or perhaps there
is a core file that could be looked at?  The other animals are not
showing anything for the moment.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (41+ messages)  latest in thread

Message-ID: <ZR-pSNRTY2izuNdg@paquier.xyz>
Permalink:  ../ZR-pSNRTY2izuNdg@paquier.xyz/
Also on:    postgresql.org/message-id/ZR-pSNRTY2izuNdg@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, bharath.rupireddyforpostgres@gmail.com, bertranddrouvot.pg@gmail.com, andres@anarazel.de
  Subject: Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag
  In-Reply-To: <ZR-pSNRTY2izuNdg@paquier.xyz>
  References: <ZRZsg2pqrCQ9dlsn@paquier.xyz> <eea89922-70e2-4a50-b990-4c6a9757a840@gmail.com> <ZRp8t67SqcF2oYqM@paquier.xyz> <566c1686-c80b-4d4a-b496-b00ac428a095@gmail.com> <ZR0EEUyWA1Nuz6CK@paquier.xyz> <83f72bb9-f3cf-4344-8d4d-45e128813d58@gmail.com> <ZR5FRByOl2y8dORo@paquier.xyz> <26e7cd6a-6dd1-4b08-975b-62603eeb6f3f@gmail.com> <CALj2ACUJf8ftjiTiNfuVKTvUM3N++dWKnhBOg1EJ29CwoTkXew@mail.gmail.com> <ZR9QJrNJ8lJDZ41P@paquier.xyz> <ZR-pSNRTY2izuNdg@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox