pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Vik Fearing <vik@postgresfriends.org>
Cc: cary huang <hcary328@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Add support for AT LOCAL
Date: Mon, 16 Oct 2023 10:28:27 +0900
Message-ID: <ZSyRu0K4JS2lh7RI@paquier.xyz> (raw)
In-Reply-To: <2149166.1697410024@sss.pgh.pa.us>
References: <e3b4c42d-739d-4375-9401-2f62ad59d326@postgresfriends.org>
	<ZSTUWON7DOfo-2ES@paquier.xyz>
	<a2bd6444-7fe4-44cd-8cb6-d7ac13f4d3e0@postgresfriends.org>
	<ZSjCZJrxGL0-wv-G@paquier.xyz>
	<65b620bd-4f05-4381-97c3-5ec9ac39d5b9@postgresfriends.org>
	<ZSjQj34RZBY_HY0c@paquier.xyz>
	<CA+hUKGK=DOC+hE-62FKfZy=Ybt5uLkrg3zCZD-jFykM-iPn8yw@mail.gmail.com>
	<2129576.1697407071@sss.pgh.pa.us>
	<CA+hUKGJE7rfnswHh021=vJmV3wAjmWfbb2BGp6CfeMk0rPyPLQ@mail.gmail.com>
	<2149166.1697410024@sss.pgh.pa.us>

On Sun, Oct 15, 2023 at 06:47:04PM -0400, Tom Lane wrote:
> Another possibly interesting factoid: it appears that before
> 97957fdba, we had zero regression test coverage of timetz_zone ---
> and we still have none of timetz_izone, which contains essentially
> the same code.  So if there is a problem here, whether it's ours or
> the compiler's, it's not hard to see why we didn't notice.

Right.  This one is just a lucky, or say unlucky find.  I didn't
notice that this path was entirely missing coverage, planting an
assertion in the middle of timetz_zone() passes check-world.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (60+ messages)  latest in thread

Message-ID: <ZSyRu0K4JS2lh7RI@paquier.xyz>
Permalink:  ../ZSyRu0K4JS2lh7RI@paquier.xyz/
Also on:    postgresql.org/message-id/ZSyRu0K4JS2lh7RI@paquier.xyz

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, vik@postgresfriends.org, hcary328@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Add support for AT LOCAL
  In-Reply-To: <ZSyRu0K4JS2lh7RI@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox